fix(ohos): Failed to play on a HarmonyOS device.#347
Merged
Conversation
qinshah
commented
Apr 29, 2026
qinshah
commented
Contributor
- fix fvp_plugin inconsistency between the output name and the libfvp_plugin.so library name
- fix fvp_plugin inconsistency between the output name and the libfvp_plugin.so library name
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the OUTPUT_NAME property in the CMakeLists.txt file for the OpenHarmony platform, changing it from 'fvp' to 'fvp_plugin'. A review comment suggests using the ${PLUGIN_NAME} variable instead of a hardcoded string to improve maintainability and ensure consistency.
Update CMakeLists.txt to set the output name of the shared library to the value of ${PLUGIN_NAME} instead of a hardcoded "fvp_plugin".
Owner
|
我最近把生成的文件名_plugin后缀都去掉了, ohos的可能没改全没测试，估计应该修改 这行而不是cmake，你试试改成 |
Contributor
Author
好的，但也得把 |
Update CMakeLists.txt, NAPI_MODULE macro, and the TypeScript import to use 'fvp' instead of the plugin name for the shared library output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.