fix(darwin): change SPM to dynamically link the framework#359
Merged
Conversation
With the introduction of SPM the framework gets statically linked resulting in '/usr/lib/fvp.framework/fvp' (no such file, not in dyld cache), 'fvp.framework/fvp' (no such file). This PR changes this so that it gets dynamically linked and fixes this issue. Devices tested: - iOS Simulator - Physical iPhone (Debug) - Physical iPhone (Release)
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Swift package configuration in 'darwin/fvp/Package.swift' to define the library as dynamic and link the 'Flutter' framework. The review feedback correctly identifies that unconditionally linking 'Flutter' will cause build failures on macOS, where the framework is named 'FlutterMacOS', and provides a code suggestion to conditionally link the appropriate framework based on the platform.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Owner
|
runs fine now. thanks. |
Owner
|
0.37.2 is published |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the introduction of SPM the framework gets statically linked resulting in:
This PR changes this so that it gets dynamically linked and fixes the issue.
Devices tested: