Add specialized review skill to command-signatures - #298
Add specialized review skill to command-signatures#298warp-agent-staging[bot] wants to merge 1 commit into
Conversation
|
@warp-agent-staging[bot] I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR adds a repository-local review-pr-local skill for command-signatures, primarily documenting review standards for command specs and generators.
Concerns
- The new guidance tells reviewers to set
verdicttoRequest changes, which conflicts with the parent review schema whereverdictmust beAPPROVEorREJECT. This can cause future review runs to emit invalidreview.json.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
| - A valid screenshot shows the completions **dropdown menu** with real, generator-produced entries next to the cursor. | ||
| - A screenshot showing the command typed without a visible dropdown, or a dropdown with no entries, is **not valid**. | ||
| - Screenshots must be embedded in the PR body as markdown images — not committed as files in the repo. | ||
| - If any added or modified generator lacks a valid screenshot, set the verdict to `Request changes` and request one explicitly. This applies even if all other review criteria pass. |
There was a problem hiding this comment.
verdict is the JSON field name in the parent review contract, and it only accepts APPROVE or REJECT; refer to the human-readable recommendation or map explicitly to verdict: "REJECT" so future reviewers do not emit invalid review.json.
| - If any added or modified generator lacks a valid screenshot, set the verdict to `Request changes` and request one explicitly. This applies even if all other review criteria pass. | |
| - If any added or modified generator lacks a valid screenshot, set the final recommendation to `Request changes` (which maps to `verdict: "REJECT"` in the core review JSON schema) and request one explicitly. This applies even if all other review criteria pass. |
1 participant
Summary
Adds a repo-local specialized review skill at
.agents/skills/review-pr-local/SKILL.md(+54/-0, one new file). This carries over the single commit8d5b5fa("add specialized review skill", authored by Andy Carlson) from the existing PR #289 into a fresh PR againstmain, as requested. PR #289 is left open and untouched.Verification
Testing-exempt category: pure content / copy — a
SKILL.mdmarkdown/skill document with no executable behavior, no Rust or JSON changes, and no UI. Verified by diff-equivalence: the new file's patch is byte-identical to commit8d5b5fa, and the diff againstmainis a single added file (+54/-0). Repo documented checks run and pass:npm run format:check(JSON specs) andcargo fmt --check. The change touches no Rust or JSON, so the Rust build/test suite is unaffected and covered by the PR's CI.Originating thread: https://warpdev.slack.com/archives/C0BDQDW8V5E/p1785882917160109