Port Fig postProcess, token-aware generators, and filters by warp-agent-staging[bot] · Pull Request #392 · warpdotdev/command-signatures

warp-agent-staging · 2026-09-03T18:33:45Z

Summary

Stacked on #391. Ports remaining structured Fig postProcess parsers, token-aware custom generators, and recovered filepaths({extensions}) template filters. Does not implement generateSpec.

Changes

Token-aware generators for degit GitHub repos, git-flow type branches, dd conv, man -S sections, file --parameter keys, esbuild loaders, robot variables/tags/test cases, and scc languages/format-multi
JSON generatorName wiring for previously stripped custom sites (apt, brew, bun, cargo, chown, docker, eslint, expo, gh, ni, npm, nx, pnpm, rush, st2, trivy, yarn, youtube-dl, and the commands above)
Template filters recovered from withfig filepaths({extensions}) / equals generators and wired via filterTemplateName
Runtime lookup alignment: deno doc doc_json, Hub generators keyed hub, fig-teams@latest.json, plus j / tns / nativescript / phpunit-watcher
deno doc token builder joins the filtered original stream (no duplicate deno doc); DocNode parser reads {version,nodes:[name,jsDoc.doc]}

Verification

cargo test --workspace --lib: 176 + 10 passed
cargo fmt, cargo clippy --all-targets --all-features -- -D warnings: passed
Prettier and all GitHub CI checks: passed
Runtime registry audit versus Port Fig generators to Rust #391: 61 reachable generator registrations, 47 reachable filters, zero newly missing or orphaned references
Local Warp GUI matrix: 155/155 cases exercised across four isolated builds
- 94/94 filter accept/reject cases passed
- 55/61 generator registrations passed through the real completion UI
- 6/61 generators are blocked by existing Warp-side token binding, with their Rust callbacks separately verified and no remaining command-signatures semantic failures
Known Warp-side binding limits:
- dd conv=: dashless options and requiresSeparator do not bind in the legacy completer (evidence)
- esbuild --loader: / --banner:: the completer splits option arguments only on =, not : (evidence)
- @-prefixed Nx and NativeScript values: Warp's global mention picker intercepts the active token; empty/non-@ controls prove generator output (Nx, NativeScript, ns, tns)

Local Warp videos

Generator screenshots

Shard 0 — 15 generator registrations

bun:npms_search

dd:conv_remaining — Warp binding limitation

deno:doc_json

elm:elm_packages

expo:npms_search

gh:repo_list_owner

hub:branches_no

hub:settings_generator

hub:tag

nativescript:nativescript_templates — semantic dropdown proof

nx:plugin_list — semantic dropdown proof

robot:variables

st2:users_or_groups

trivy:pkg_types_remaining

yarn:npms_search

Shard 1 — 15 generator registrations

cargo:crates_io_search

degit:github_user_repos

deployctl:deploy_versions

esbuild:loader — Warp colon-separator limitation

fig-teams@latest:teams_list

git-flow:type_branches

hub:log

hub:stashes

hub:treeish

ni:npms_search

phpunit-watcher:tests

rush:npms_search

stepzen:github_schemas

trivy:scanners_remaining

youtube-dl:flat_playlist

Shard 2 — 16 generator registrations

apt:list_prefix

cargo:test_list

cargo:test_targets

deno:deno_binaries

docker:from_as

eslint:env_remaining

fig-teams@latest:users_for_selected_team

hub:aliases

hub:remotes

hub:status

j:cat

npm:npms_search

pnpm:npms_search

rustup:rustup_docs

tailscale:peers_colon

trivy:severity_remaining

Shard 3 — 15 generator registrations

brew:gist_logs_actions

chown:users_or_groups

deno:deno_versions

docker:search

expo-cli:npms_search

file:param_keys

hub:branches

hub:revs

hub:status_staged_or_unstaged

man:sections_remaining

ns:nativescript_templates — semantic dropdown proof

robot:test_cases

scc:format_multi

tns:nativescript_templates — semantic dropdown proof

yarn:create_package_search

warp-agent-staging · 2026-09-03T18:35:09Z

This PR was generated with Warp.

Comment @warp-factory on this PR to send it follow-up work.

Replace line-split parsing with shared helpers for JSON, tables, and other structured Fig postProcess. Add a token-aware Fig Teams user generator.

Add shared file/folder filters for Python, YAML playbooks, direnv .envrc, and ts-node tsconfig, recovered from original Fig filepaths generators.

Rename fig_parse/fig_filters/fig_teams_latest to output_parsers, template_filters, and fig_teams. Use semantic generator names for Teams users/teams. Add token-aware generators for cargo, docker, gh, apt, bun, trivy, chown, and related commands.

Wire token-aware custom generators (degit, git-flow, dd, man, file, esbuild, robot, scc) and recover filepaths({extensions}) filters from withfig sources onto JSON filterTemplateName.

Replace line-split callbacks for ansible-doc, tailscale peers, 1Password accounts, projj cache/hooks, trex imports/scripts, turbo pipeline, cargo read-manifest bins, and elm package search with the original object-specific postProcess mappings.

…mantics Parse Docker search JSON-lines, StepZen schema/GitHub contents, youtube-dl playlist JSON, and Lerna package.json END streams. Map other non-name-only line registrations to description, git-branch, YAML hook-id, and related structured callbacks.

Parse ~/.ssh/known_hosts host fields (comma lists, hashed skip, user@ prefix) for mosh/sftp/ssh instead of SSH-config Host directives. Walk pre-commit YAML repos[].hooks[].id scalars instead of matching raw id: text.

Sequence items at the same column as `repos:` or `hooks:` stay in that container; sibling mappings still end it. Quoted hook IDs strip wrapping quotes before comments.

Wire deno doc_json, register hub generators under hub, rename fig-teams.json to match fig-teams@latest, and align other filename/registry mismatches so JSON generatorName values resolve.

Join the filtered original token stream instead of prepending `deno doc`, and parse `deno doc --json` `{version, nodes}` using node name and jsDoc.doc.

Preserve the `conv=` token prefix so remaining conversion names match, and remove leftover filepaths templates from Trivy remaining-enum args.

Parse hub status --short as paths, list Linux groups with a colon prefix, and keep scc -f on remaining formats instead of colon path completion.

Keep the fatal: guard on a trimmed view of the whole output, but slice column 3 from the original status line so a leading space in XY is not eaten before the path.

…, and j Wire npms_search on top-level pnpm add. Expand $PWD/Dockerfile instead of single-quoting it, and drop leftover filepaths from docker --target. Do not grep cargo test -- --list for the --test flag, attach test_list to TESTNAME, and read autojump's Linux db path as well as the macOS one.

Warp's case-sensitive lookup rejects a spec whose name field differs from the filename token, so hub.json named git never attached. Match each spec name to its file, and send a GitHub User-Agent when listing NativeScript templates.

Keep test_list on positional TESTNAME. --test now uses cargo metadata targets whose kind contains test, matching names like integration_target rather than test function names.

contains(\".envrc\") accepted .envrc.txt. Keep folders for navigation and only boost files named .envrc.

GNU find treats -depth as a boolean, so -depth 3 failed with paths must precede expression. Use -maxdepth 3, and still emit loader types when Warp splits --loader: so the last token has no colon.

-maxdepth is not portable across BSD find. Keep -type f, name filter, and node_modules exclusion so GNU and macOS find both list extensions.

Print the first N :: segments so shardmod::case matches shardmod::case_alpha, and stop putting HostName in display_name so Warp prefixes match shard-peer:.

## Description Bump `warp-command-signatures` (and the locked `warp-completion-metadata` from the same git source) from `6a39d62048abbf3885be54a7887f1916ebcf7445` to `d69b340ef622540ac28340ef565dae45287d51d8`. That revision includes [command-signatures#391](warpdotdev/command-signatures#391) and [command-signatures#392](warpdotdev/command-signatures#392) (Rust Fig generators and template filters). Lockfile sources for both packages were updated to the same rev. Unrelated `cargo update` resolution churn was not included. ## Linked Issue - [APP-5776](https://linear.app/warpdotdev/issue/APP-5776/port-fig-javascript-argument-generators-and-template-filters-to-rust) ## Testing Verification was not run, at the requester’s direction. - [ ] I have manually tested my changes locally with `./script/run` ## Agent Mode - [ ] Warp Agent Mode - This PR was created via Warp's AI Agent Mode CHANGELOG-NONE   Co-authored-by: warp-agent-staging[bot] <240773466+warp-agent-staging[bot]@users.noreply.github.com>

cla-bot Bot added the cla-signed label Sep 3, 2026

warp-agent-staging Bot added the factory:wilson label Sep 3, 2026

warp-agent-staging Bot changed the title ~~factory/port fig postprocess~~ Port Fig postProcess, token-aware generators, and filters Sep 3, 2026

warp-agent-staging Bot requested a review from acarl005 September 3, 2026 18:34

acarl005 marked this pull request as ready for review September 3, 2026 18:37

warp-agent-staging Bot marked this pull request as draft September 3, 2026 18:46

warp-agent-staging Bot marked this pull request as ready for review September 3, 2026 19:12

acarl005 self-assigned this Sep 3, 2026

acarl005 approved these changes Sep 4, 2026

View reviewed changes

warp-agent-staging Bot added 20 commits September 3, 2026 19:56

Port structured Fig postProcess and token-aware Teams users

e5fa697

Replace line-split parsing with shared helpers for JSON, tables, and other structured Fig postProcess. Add a token-aware Fig Teams user generator.

Port recovered Fig template filters

e3a5a38

Add shared file/folder filters for Python, YAML playbooks, direnv .envrc, and ts-node tsconfig, recovered from original Fig filepaths generators.

Port remaining Fig custom generators and template filters

34e7ed4

Wire token-aware custom generators (degit, git-flow, dd, man, file, esbuild, robot, scc) and recover filepaths({extensions}) filters from withfig sources onto JSON filterTemplateName.

Fix known_hosts hostname parsing and pre-commit YAML hook IDs

685445a

Parse ~/.ssh/known_hosts host fields (comma lists, hashed skip, user@ prefix) for mosh/sftp/ssh instead of SSH-config Host directives. Walk pre-commit YAML repos[].hooks[].id scalars instead of matching raw id: text.

Keep indentless YAML sequences inside pre-commit repos and hooks

61ac633

Sequence items at the same column as `repos:` or `hooks:` stay in that container; sibling mappings still end it. Quoted hook IDs strip wrapping quotes before comments.

Key dynamic generators to the command Warp looks up

a0bd1d6

Wire deno doc_json, register hub generators under hub, rename fig-teams.json to match fig-teams@latest, and align other filename/registry mismatches so JSON generatorName values resolve.

Fix Deno doc token command and DocNode envelope parser

03b5cf9

Join the filtered original token stream instead of prepending `deno doc`, and parse `deno doc --json` `{version, nodes}` using node name and jsDoc.doc.

Fix dd conv= remaining suggestions and drop Trivy filepaths

323a28a

Preserve the `conv=` token prefix so remaining conversion names match, and remove leftover filepaths templates from Trivy remaining-enum args.

Fix hub staged-file parser, chown groups, and scc -f remaining

1763ec8

Parse hub status --short as paths, list Linux groups with a colon prefix, and keep scc -f on remaining formats instead of colon path completion.

Slice git status --short paths from untrimmed XY lines

f205ca5

Keep the fatal: guard on a trimmed view of the whole output, but slice column 3 from the original status line so a leading space in XY is not eaten before the path.

Suggest Cargo --test integration targets from metadata

9d2956b

Keep test_list on positional TESTNAME. --test now uses cargo metadata targets whose kind contains test, matching names like integration_target rather than test function names.

Match direnv file completions to basename .envrc

e364a9b

contains(\".envrc\") accepted .envrc.txt. Keep folders for navigation and only boost files named .envrc.

Use portable find for esbuild loader extension fallback

a0fdaff

GNU find treats -depth as a boolean, so -depth 3 failed with paths must precede expression. Use -maxdepth 3, and still emit loader types when Warp splits --loader: so the last token has no colon.

Drop maxdepth from esbuild loader find fallback

76992f7

-maxdepth is not portable across BSD find. Keep -type f, name filter, and node_modules exclusion so GNU and macOS find both list extensions.

Keep cargo test module prefixes and Tailscale peer match text

e3b09c9

Print the first N :: segments so shardmod::case matches shardmod::case_alpha, and stop putting HostName in display_name so Warp prefixes match shard-peer:.

acarl005 force-pushed the factory/port-fig-postprocess branch from ee91968 to e3b09c9 Compare September 4, 2026 02:56

acarl005 merged commit d69b340 into main Sep 4, 2026
8 checks passed

acarl005 deleted the factory/port-fig-postprocess branch September 4, 2026 02:59

warp-agent-staging Bot mentioned this pull request Sep 4, 2026

[APP-5776] Bump command-signatures for Rust Fig generators warpdotdev/warp#15791

Merged

2 tasks

Navigation Menu

Uh oh!

Port Fig postProcess, token-aware generators, and filters - #392

Port Fig postProcess, token-aware generators, and filters#392
acarl005 merged 20 commits into
factory/port-fig-generatorsfrom
factory/port-fig-postprocess

warp-agent-staging Bot commented Sep 3, 2026 •

edited

Loading

Uh oh!

warp-agent-staging Bot commented Sep 3, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

warp-agent-staging Bot commented Sep 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Verification

Local Warp videos

Generator screenshots

Uh oh!

warp-agent-staging Bot commented Sep 3, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

warp-agent-staging Bot commented Sep 3, 2026 •

edited

Loading