fix: replace on-call reviewer assignment with Slack notification + last-reviewer#307
Merged
Merged
Conversation
…st-reviewer - Remove Grafana-based on-call resolver entirely from workflow and skill - Oz agent now posts to #growth-docs Slack mentioning @oncall-client-primary after creating the PR (uses SLACK_BOT_TOKEN + GROWTH_DOCS_SLACK_CHANNEL_ID) - GitHub Actions now finds the last human reviewer from recent merged docs PRs and assigns them to the new PR (reliable fallback to dannyneira) - Remove assign_oncall_reviewers workflow input and all related env vars Requires: add SLACK_BOT_TOKEN and GROWTH_DOCS_SLACK_CHANNEL_ID to the docs Oz environment (K5KStCm5aYvhfBJb8cHol6) via the agent page. Co-Authored-By: Oz <oz-agent@warp.dev>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-Authored-By: Oz <oz-agent@warp.dev>
Co-Authored-By: Oz <oz-agent@warp.dev>
Co-Authored-By: Oz <oz-agent@warp.dev>
Co-Authored-By: Oz <oz-agent@warp.dev>
Contributor
There was a problem hiding this comment.
Overview
Reviewed the release docs workflow change that replaces Grafana on-call reviewer resolution with Slack notification instructions and a GitHub Actions last-reviewer assignment step.
Concerns
- The new reviewer lookup likely calls the pulls endpoint with POST semantics because it passes
-Ffields togh apiwithout forcing GET, so the action can skip the intended last-reviewer assignment and fall back to the default reviewer. - The last-reviewer logic only inspects the newest merged PR instead of scanning recent merged PRs until it finds a human reviewer, which can incorrectly fall back when the newest merged PR has no human review.
- The Slack notification example in the release update skill references names that are not defined/imported, so agents following it can fail before posting or while handling Slack errors.
Verdict
Found: 0 critical, 4 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
hongyi-chen
approved these changes
Jul 9, 2026
…e PRs - Add 'import sys' to SKILL.md Slack snippet - Add pr_url comment showing how to obtain it from gh pr view - Fix gh api pulls endpoint to use query string params instead of -F flags (avoids unintended POST semantics) - Iterate over recent merged PRs until a human reviewer is found, instead of only checking the single most recently merged PR Co-Authored-By: Oz <oz-agent@warp.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the fragile Grafana-based on-call reviewer assignment with two simpler, more reliable mechanisms:
#oncall-client(C06MT1NRBFV) mentioning@oncall-client-primaryand@oncall-client-secondaryafter creating the PR. Grafana keeps those Slack user groups in sync with the rotation automatically — no Grafana API calls needed.dannyneiraif none found.The PR is created with auto-merge enabled, so once the assigned reviewer approves it merges automatically.
Changes
.github/workflows/release-docs-update.ymlassign_oncall_reviewersworkflow input and all related env vars/normalizationoncall-client-primaryandoncall-client-secondarygroup IDs viausergroups.list, posts to#oncall-clientpulls/{n}/reviewson recent merged PRs to find the last human reviewer.agents/skills/release_updates/SKILL.mdDOCS_SLACK_BOT_TOKENonly — channel ID is hardcoded)@oncall-client-primaryand@oncall-client-secondary.agents/skills/release_updates/scripts/resolve_oncall_reviewers.pySlack message format
Oz environment changes required
Add to the docs Oz environment (
K5KStCm5aYvhfBJb8cHol6) at https://oz.warp.dev/agents/019eb332-2ee0-7417-8ecc-89260cf5b850:DOCS_SLACK_BOT_TOKEN— Slack bot token for posting to#oncall-clientRemove from the docs Oz environment (no longer needed):
DOCS_AGENT_GRAFANA_TOKENONCALL_EMAIL_TO_GITHUB_OVERRIDESAlso ensure the bot is a member of
#oncall-client(/invite @botnamein that channel).Co-Authored-By: Oz oz-agent@warp.dev