docs(factories): fix the quickstart's factory-creation entry point - #559
Merged
hongyi-chen merged 1 commit intoAug 18, 2026
Merged
Conversation
…an label Verified the factory setup entry points against warp-server client/packages/factory: - FactoryOnboardingGate redirects any user with no factory to /onboarding, which renders the Welcome screen and its "Let's get started" button. A first-time reader never sees the sidebar, so the "+ next to Factories" instruction only applies once the team already has a factory. - The identity step's alias field is labeled "Foreman name", not "Factory alias", as of warp-server 9e3649c4. Confirms the "+" affordance itself is correct (AppSidebar.tsx renders a Plus link with aria-label "Create factory"); there is no "New factory" button anywhere in the Factory web app. Co-Authored-By: Warp <agent@warp.dev>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
Author
|
This PR was generated with Warp. Comment   |
Contributor
|
Your Warp account is not a member of any team with access to this repository. |
Contributor
|
I'm starting a first review of this pull request. You can follow along in the session on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Overview
This PR updates the factories quickstart to send first-time users through the welcome screen entry point, preserves the sidebar + path for teams that already have a factory, and updates stale Factory alias terminology to Foreman name.
Concerns
- No blocking concerns found. The changed MDX stays within the existing quickstart flow, adds no commands or links, and the provided spec context reports no approved or repository spec context to check against.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
guyscherzer8
pushed a commit
that referenced
this pull request
Aug 18, 2026
… Foreman name label, drop the redundant credits note Co-Authored-By: Warp <agent@warp.dev>
hongyi-chen
added a commit
that referenced
this pull request
Aug 18, 2026
…uide references (#560) Second consistency pass over the launch stack, cross-checking the docs against the product and against each other after #557/#558/#559 landed. Verified against warp-server (no change needed): - The alias constraints in factory-as-code match the shared factoryalias.Normalize contract (60 runes; letters, digits, spaces, '-', '_', '.'; case-insensitive uniqueness). - Activity's terminal stage really is labeled 'Complete' while the Slack Home tab uses 'Completed' (slack_app_home.go) — both pages correctly reflect their own surface, so the apparent mismatch stands. Aligned: - factory-as-code: bridge the alias key to its control-room label, Foreman name (#559 introduced the label in the quickstart), and say it @-mentions the foreman, matching the UI copy. - control-room Settings: name the identity fields (name, avatar, Foreman name) and link Foreman name to the alias reference. - run-a-software-factory-in-the-cloud: DIY-loop runs appear in the cloud agent dashboard, not the Factories product's dashboard — use {VARS.DASHBOARD}. - The five DIY-factory guides framed the Factories product page as 'the conceptual overview of the full loop'; their next-step descriptions now say what the destination is (the managed product), and build-a-self-improving-agent deep-links the Self-improvement section it parallels (the reverse link already existed). - set-up-a-software-factory and run-a-software-factory-in-the-cloud intros now point readers to Warp Factories as the managed alternative. Validated: npm run build passes; link checker 3,664 internal / 1,522 external, 0 broken; style_lint adds no new findings on touched files. Co-authored-by: hongyi-chen <hongyigma@gmail.com> Co-authored-by: Warp <agent@warp.dev> Co-authored-by: Hong Yi Chen <hongyi@warp.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to a review question on #526: the GitHub integration page says
click **+** next to **Factories**, and Rachael asked whether the quickstart's wording (click **New factory**) was the correct one instead.I verified both against
warp-server/client/packages/factory.What the codebase says
The
+is correct. There is no "New factory" button anywhere in the Factory web app.AppSidebar.tsxrenders aPlusiconLinkwitharia-label="Create factory"next to the Factories section header, pointing atCREATE_FACTORY_FIRST_STEP_PATH(/create/codeforge-setup). This is covered bynavigation.test.tsx("shows the Create factory link in the sidebar") andmount.test.tsx. Grepping the whole package for "New factory" returns nothing.So #526 needs no change on that point, and the quickstart on
hyc/factory-launchalready says+too. The discrepancy Rachael saw was against a stale draft.What is actually wrong (fixed here)
Verifying the
+surfaced two real problems infactories/quickstart.mdx:1. The
+is unreachable for the quickstart's own audience.FactoryOnboardingGateredirects any user whose team has no factory to/onboarding, andOnboardingPagerenders theWelcomescreen with a Let's get started button (Welcome.tsx). A first-time reader never sees the app shell, so they never see the sidebar+. The+only applies once the team already has a factory. The step now leads with the welcome screen and keeps the sidebar+as the secondary path.The note is also corrected: team and plan are prerequisite steps that run before the welcome screen (
firstUnmetPrerequisiteinOnboarding/index.tsx), not something "the wizard will ask" mid-flow.2. "Factory alias" is a stale UI label.
warp-server
9e3649c4("factory: reword stale 'alias' copy to 'Foreman name'") renamed the field.IdentitySetupStep.tsxnow renderslabel="Foreman name"with the hint "This is the name you will use to @-mention your factory foreman in other integrated platforms." Updated the quickstart to match.aliasremains correct as the YAML field name infactory-as-code.mdx, so that page is unchanged.Also verified as still accurate (no change needed)
I want to use repos from GitHub(CodeforgeSetupStep.tsx),Select your repos/Add repos(types.ts), the Triage / Spec / Code / Review toggles and the Code →IMPLEMENTmapping (AgentsStep.tsx), andFactory running!/Go to dashboard(Summary.tsx).Validation
npm run buildpasses (only the pre-existing/404route-priority warning)style_lint.py --changedreports no new issues forfactories/quickstart.mdxCo-Authored-By: Warp agent@warp.dev