Improve Key terms on Factories overview page - #641
Conversation
- Replace awkward 'They're not:' preface with a natural introduction - Add a factory definition to the Key terms list - Keep foreman capitalization consistent with terminology.md
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@warp-agent-staging[bot] I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![warp-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR updates the Factories overview Key terms section to clarify factory/foreman naming and add a factory definition. The change is scoped and fits the existing page structure, with one terminology wording tweak suggested.
Concerns
- The new factory definition should align more closely with
.agents/references/terminology.mdby defining a factory as an instance of a software factory, not as an instance of Warp Factories.
Verdict
Found: 0 critical, 0 important, 1 suggestions
Approve with nits
Comment /warp-agent-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
Redefine factory as an individual deployed instance of a software factory built on Warp Factories infrastructure, matching .agents/references/terminology.md, rather than describing it as an instance of Warp Factories itself.
caab458 to
88e5392
Compare
1 participant
Summary
Improves the Key terms section on the public Warp Factories overview page (
/factories/#key-terms) per requester feedback:They're not:preface with a natural sentence introducing the terms..agents/references/terminology.md.foremancapitalization is already consistent with the terminology reference (lowercase for the agent role,Foreman namecapitalized only as the UI field name) — left unchanged.Change is scoped to the Key terms section only; no other page content was touched.
Verification
python3 .agents/skills/style_lint/style_lint.py --changed— 0 new issues (3 pre-existingUNRECOGNIZED-TERMwarnings on unrelated lines outside the diff).python3 .agents/skills/check_for_broken_links/check_links.py --internal-only— 0 broken links (3912 internal links checked).npm run build— Astro build completes successfully.Rework changes
.agents/references/terminology.mdand keeping the term distinct from both the product (Warp Factories) and the foreman.Re-verified after the fix:
style_lint --changed(0 new issues), internal link check (0 broken links),npm run build(succeeds).Originating thread: https://warpdev.slack.com/archives/C09BVK0PL3Y/p1787765473614179