Unify PR creation codepaths for conflict/non-conflict syncs.#20
Merged
vorporeal merged 1 commit intoApr 10, 2026
Merged
Conversation
danielpeng2
approved these changes
Apr 9, 2026
2be06eb to
728e168
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Unifies the conflict and non-conflict codepaths in both
_sync_private_to_publicand_sync_public_to_private.Previously, a cherry-pick conflict caused the code to branch into a completely separate
_handle_cherry_pick_conflictfunction that duplicated much of the standard flow (description building, trailer appending, push, PR creation). This made it easy for the two paths to drift — most recently, conflict PRs were getting[CONFLICT]prepended to their titles and losing their original PR descriptions.Now both functions follow a single linear flow with
is_conflictconditionals at the points where behavior differs:is_conflictOther changes:
[CONFLICT]prepended to their title.GhOps.add_pr_comment()method.Testing
All 251 existing tests pass. Verified via manual inspection of a conflict sync PR (warpdotdev/warp-internal#24195).
Co-Authored-By: Oz oz-agent@warp.dev