fix: improve network log readability and copying by princepal9120 · Pull Request #10062 · warpdotdev/warp

princepal9120 · 2026-05-04T17:16:04Z

Summary

Format network log request/response entries into readable fields instead of raw debug blobs.
Preserve raw/plain-text snapshots for copying and add a Copy all header action.
Separate entries with blank lines and cover snapshot behavior in tests.
Address review feedback by using the existing Flex::row().with_spacing(...).with_child(...) API and notifying the view after snapshot refresh.

Fixes #9716

Testing

git diff --check
Attempted cargo test -p warp network_logging, but this machine ran out of disk while compiling dependencies.

oz-for-oss · 2026-05-04T17:16:17Z

@princepal9120

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

oz-for-oss

Overview

This PR reformats network log entries for display, preserves a plain-text copy snapshot, and adds a Copy all header action.

Concerns

The new header layout uses Flex::new(vec![...]), .gap(...), and Length, which do not match the existing Warp UI API and will not compile.
Refreshing an initially empty pane updates latest_plain_text without notifying the view, so the header can remain rendered without the Copy all button after entries appear.

Found: 1 critical, 1 important, 0 suggestions

Verdict

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

oz-for-oss · 2026-05-04T17:30:40Z

+            left_of_overflow: Some(if self.snapshot_is_empty() {
+                self.render_refresh_button(app)
+            } else {
+                Flex::new(vec![self.render_copy_button(app), self.render_refresh_button(app)])


🚨 [CRITICAL] This does not compile: Flex::new expects an Axis, and this codebase uses Flex::row().with_spacing(...).with_child(...); Length/.gap() are not available, so the new import is also unresolved.

oz-for-oss · 2026-05-04T17:30:40Z

-        let snapshot = NetworkLogModel::as_ref(ctx).snapshot_text();
+    pub fn reload_snapshot(&mut self, ctx: &mut ViewContext<Self>) {
+        let snapshot = NetworkLogModel::as_ref(ctx).snapshot();
+        self.latest_plain_text = snapshot.plain_text;


⚠️ [IMPORTANT] After changing latest_plain_text, notify this view; otherwise refreshing an initially empty pane after entries arrive can update the editor while leaving the header rendered without the Copy all button.

princepal9120 · 2026-05-13T04:52:50Z

The review feedback is addressed in the current branch:

The header uses the existing Warp UI API: Flex::row().with_spacing(...).with_child(...).
reload_snapshot updates latest_plain_text, refreshes the editor, and calls ctx.notify() so the Copy all button appears after refreshing from an initially empty snapshot.
Updated the PR body with the current validation note.

Local validation completed: git diff --check. I attempted cargo test -p warp network_logging, but this runner ran out of disk while compiling dependencies.

/oz-review

oz-for-oss · 2026-05-13T04:53:07Z

@princepal9120

I'm re-reviewing this pull request in response to a review request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

oz-for-oss

Overview

This PR formats network log entries for readability, preserves a raw plain-text snapshot for Copy all, and adds tests for snapshot joining/copy behavior.

Concerns

The formatted request and response display drops headers that were previously visible through the debug output, which removes important network debugging context from the pane.

Verdict

Found: 0 critical, 2 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

oz-for-oss · 2026-05-13T04:57:36Z

+        .query()
+        .map_or(String::new(), |query| format!("?{query}"));
+
+    let mut lines = vec![


⚠️ [IMPORTANT] The formatted request snapshot omits request.headers(), so users lose header values like content type, request IDs, and auth redaction markers that were visible in the previous debug output and are often necessary for diagnosing network issues. Include a readable header section in display_text while keeping plain_text raw.

oz-for-oss · 2026-05-13T04:57:36Z

+        .query()
+        .map_or(String::new(), |query| format!("?{query}"));
+
+    [


⚠️ [IMPORTANT] The response display no longer includes response.headers(), which removes useful debugging context such as rate-limit, content-type, cache, and request-ID headers from the pane. Add headers to the formatted response output or otherwise preserve that header content in the display snapshot.

github-actions · 2026-06-05T15:04:21Z

Hi @princepal9120 — a reviewer requested changes on this PR and it hasn't had activity from you in 23 days. When you get a chance, please push updates or reply to the review so a reviewer can take another look. Without activity, this PR will be automatically closed after 30 days of inactivity.

Previously, format_request_for_display and format_response_for_display omitted HTTP headers from the display text, losing debugging context that was previously visible via the Debug formatter. Co-authored-by: Claude Haiku 4.5 <noreply@anthropic.com>

princepal9120 · 2026-06-07T17:21:08Z

/oz-review

Latest commit adds HTTP headers to both request and response display output, restoring the debugging context that was previously visible via the Debug formatter. Headers are now shown in the display_text for both format_request_for_display and format_response_for_display.

oz-for-oss · 2026-06-07T17:21:25Z

@princepal9120

I'm re-reviewing this pull request in response to a review request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

oz-for-oss

Overview

This PR updates the network log pane to render request/response entries in a more readable format, keeps a raw/plain-text snapshot for copying, adds a Copy all header action, and updates snapshot tests for the new blank-line formatting.

Concerns

⚠️ [IMPORTANT] This is a user-facing UI/behavior change, but the PR description does not include a screenshot or screen recording demonstrating the updated network log rendering and Copy all action end to end. Repo review guidance requires visual evidence for user-visible changes before approval.

Verdict

Found: 0 critical, 1 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

fix: improve network log readability and copying

32f22de

cla-bot Bot added the cla-signed label May 4, 2026

github-actions Bot added the external-contributor Indicates that a PR has been opened by someone outside the Warp team. label May 4, 2026

princepal9120 mentioned this pull request May 4, 2026

Improve network log readability and copying #10063

Closed

oz-for-oss Bot requested changes May 4, 2026

View reviewed changes

princepal9120 added 2 commits May 5, 2026 03:01

fix: address network log review feedback

d247c96

style: format network log helpers

6b09a9a

oz-for-oss Bot requested changes May 13, 2026

View reviewed changes

oz-for-oss Bot requested changes Jun 7, 2026

View reviewed changes

Conversation

princepal9120 commented May 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Testing

Uh oh!

oz-for-oss Bot commented May 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oz-for-oss Bot left a comment

Choose a reason for hiding this comment

Overview

Concerns

Verdict

Uh oh!

oz-for-oss Bot May 4, 2026

Choose a reason for hiding this comment

Uh oh!

oz-for-oss Bot May 4, 2026

Choose a reason for hiding this comment

Uh oh!

princepal9120 commented May 13, 2026

Uh oh!

oz-for-oss Bot commented May 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oz-for-oss Bot left a comment

Choose a reason for hiding this comment

Overview

Concerns

Verdict

Uh oh!

oz-for-oss Bot May 13, 2026

Choose a reason for hiding this comment

Uh oh!

oz-for-oss Bot May 13, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jun 5, 2026

Uh oh!

princepal9120 commented Jun 7, 2026

Uh oh!

oz-for-oss Bot commented Jun 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oz-for-oss Bot left a comment

Choose a reason for hiding this comment

Overview

Concerns

Verdict

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

princepal9120 commented May 4, 2026 •

edited

Loading

oz-for-oss Bot commented May 4, 2026 •

edited

Loading

oz-for-oss Bot commented May 13, 2026 •

edited

Loading

oz-for-oss Bot commented Jun 7, 2026 •

edited

Loading