Skip to content

Improve network log readability and copying#10063

Closed
princepal9120 wants to merge 1 commit into
warpdotdev:masterfrom
princepal9120:prince/network-log-9716
Closed

Improve network log readability and copying#10063
princepal9120 wants to merge 1 commit into
warpdotdev:masterfrom
princepal9120:prince/network-log-9716

Conversation

@princepal9120
Copy link
Copy Markdown
Contributor

Summary

  • replace raw reqwest debug output in the network log pane with compact multiline request/response summaries
  • keep a separate plain-text snapshot so the pane can expose a one-click Copy all action without losing the full raw text
  • add focused tests for the new snapshot formatting behavior

Testing

  • cargo test -p app network_logging --lib (not run: cargo is unavailable in this environment)

Fixes #9716

@cla-bot cla-bot Bot added the cla-signed label May 4, 2026
@github-actions github-actions Bot added the external-contributor Indicates that a PR has been opened by someone outside the Warp team. label May 4, 2026
@oz-for-oss
Copy link
Copy Markdown
Contributor

oz-for-oss Bot commented May 4, 2026

@princepal9120

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@princepal9120
Copy link
Copy Markdown
Contributor Author

Closing as duplicate of #10062. Both PRs contain the same commit for #9716, so keeping one canonical PR open.

@princepal9120 princepal9120 deleted the prince/network-log-9716 branch May 4, 2026 17:26
Copy link
Copy Markdown
Contributor

@oz-for-oss oz-for-oss Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR replaces raw reqwest debug output in the network log pane with formatted request/response summaries, adds a Copy all header action backed by a raw plain-text snapshot, and updates model tests around snapshot joining/copy preservation.

Concerns

  • This is a user-visible pane/header change, but the PR description does not include screenshots or video showing the new network log formatting and Copy all affordance end to end. For faster review, please upload screenshots or a video of the feature working end to end.
  • The new request/response display formatting path has no direct test coverage; the added copy-preservation test only exercises NetworkLogItem::from_string.

Verdict

Found: 0 critical, 1 important, 1 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

}
}

fn format_request_for_display(
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 [SUGGESTION] Add a test that constructs real request/response log items so the new display formatting stays covered while plain_text continues preserving raw debug output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed external-contributor Indicates that a PR has been opened by someone outside the Warp team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Network log is almost unusable

1 participant