Improve network log readability and copying#10063
Conversation
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR replaces raw reqwest debug output in the network log pane with formatted request/response summaries, adds a Copy all header action backed by a raw plain-text snapshot, and updates model tests around snapshot joining/copy preservation.
Concerns
- This is a user-visible pane/header change, but the PR description does not include screenshots or video showing the new network log formatting and Copy all affordance end to end. For faster review, please upload screenshots or a video of the feature working end to end.
- The new request/response display formatting path has no direct test coverage; the added copy-preservation test only exercises
NetworkLogItem::from_string.
Verdict
Found: 0 critical, 1 important, 1 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
| } | ||
| } | ||
|
|
||
| fn format_request_for_display( |
There was a problem hiding this comment.
💡 [SUGGESTION] Add a test that constructs real request/response log items so the new display formatting stays covered while plain_text continues preserving raw debug output.
Summary
Testing
Fixes #9716