add & entrypoint for local -> cloud handoff#10271
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR adds the & local-to-cloud handoff entrypoint, transient environment selection, slash-command auto-submit plumbing, and model/workspace state for optimistic handoff launches.
Concerns
- The new launch request type is referenced from always-compiled APIs while the
handoffmodule is only available withlocal_fs, which breaks non-local_fs/wasm builds. The same cfg mismatch also appears in other unguarded call sites such as slash-command/input launch handling. - Queued auto-submit handoffs can still dispatch after the user cancels the optimistic waiting state, because readiness consumes
auto_submitwithout checking whether the pane is still actively queued.
Verdict
Found: 1 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
b53e690 to
51b64cb
Compare
51b64cb to
7b335cc
Compare
ce810f2 to
45d3c88
Compare
45d3c88 to
a783c40
Compare
a783c40 to
ce38e56
Compare
## Description <!-- Please remember to add your design buddy onto the PR for review, if it contains any UI changes! --> This PR adds a new `&` entrypoint for local -> cloud handoff. This is framed in the UI similarly to the `!` input mode (and has the same semantics in terms of how it is entered and how it is exited), but with different colors and verbiage around cloud mode. This entrypoint also works as a general cloud-mode entrypoint, as using `&` with no existing conversation can just kick you directly into a cloud mode run. note: there is still some remaining work around hiding certain chips in the `&` state and adding in an environment creation flow, but I'll cover those in later PRs on top of this one ## Screenshots / Videos <!-- Attach screenshots or a short video demonstrating the change, where appropriate. Remove this section if it is not relevant to your PR. --> https://www.loom.com/share/06edd4ce738646b9863fe91c64571b46 ## Agent Mode - [x] Warp Agent Mode - This PR was created via Warp's AI Agent Mode

Description
This PR adds a new
&entrypoint for local -> cloud handoff. This is framed in the UI similarly to the!input mode (and has the same semantics in terms of how it is entered and how it is exited), but with different colors and verbiage around cloud mode.This entrypoint also works as a general cloud-mode entrypoint, as using
&with no existing conversation can just kick you directly into a cloud mode run.note: there is still some remaining work around hiding certain chips in the
&state and adding in an environment creation flow, but I'll cover those in later PRs on top of this oneScreenshots / Videos
https://www.loom.com/share/06edd4ce738646b9863fe91c64571b46
Agent Mode