Skip to content

Hide unnecessary chips when in handoff input mode#10389

Merged
harryalbert merged 1 commit intomasterfrom
harry/remote-1595-hideshow-specific-chips-when-doing-local-cloud-handoff
May 8, 2026
Merged

Hide unnecessary chips when in handoff input mode#10389
harryalbert merged 1 commit intomasterfrom
harry/remote-1595-hideshow-specific-chips-when-doing-local-cloud-handoff

Conversation

@harryalbert
Copy link
Copy Markdown
Contributor

@harryalbert harryalbert commented May 7, 2026

Description

Most of the chips in the agent view input don't make sense when you're in the & input mode. We also want to make the chip transition a little more pronounced, because when you enter the & mode we add in an environment selector chip that it would be good for people to notice.

For both of these reasons, this PR hides all of the chips in the agent view input that don't make sense for & mode when you're in & mode.

Screenshots / Videos

https://www.loom.com/share/df78cd1dade94dce834172ae38d04668

Agent Mode

  • Warp Agent Mode - This PR was created via Warp's AI Agent Mode

@cla-bot cla-bot Bot added the cla-signed label May 7, 2026
Copy link
Copy Markdown
Contributor Author

harryalbert commented May 7, 2026

@harryalbert harryalbert changed the title hide certain chips for & entry Hide unnecessary chips when May 7, 2026
@harryalbert harryalbert changed the title Hide unnecessary chips when Hide unnecessary chips when in handoff input mode May 7, 2026
@harryalbert harryalbert requested a review from zachbai May 7, 2026 18:17
@harryalbert harryalbert marked this pull request as ready for review May 7, 2026 18:17
@oz-for-oss
Copy link
Copy Markdown
Contributor

oz-for-oss Bot commented May 7, 2026

@harryalbert

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Copy link
Copy Markdown
Contributor

@oz-for-oss oz-for-oss Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR adds a render-time filter so handoff-compose mode only leaves the toolbar items relevant to composing a cloud run, while leaving the configured toolbar layout intact. It also documents the intended behavior in product and tech specs.

Concerns

  • No blocking correctness or security concerns found in the diff.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@harryalbert harryalbert force-pushed the harry/remote-1595-hideshow-specific-chips-when-doing-local-cloud-handoff branch from 63b56f5 to c792c85 Compare May 7, 2026 20:44
@harryalbert harryalbert force-pushed the harry/remote-1558-create-entrypoint-for-local-cloud-handoff branch from 51b64cb to 7b335cc Compare May 7, 2026 20:44
@harryalbert harryalbert force-pushed the harry/remote-1595-hideshow-specific-chips-when-doing-local-cloud-handoff branch 2 times, most recently from 52bdc80 to 22a2aba Compare May 7, 2026 22:24
@harryalbert harryalbert changed the base branch from harry/remote-1558-create-entrypoint-for-local-cloud-handoff to graphite-base/10389 May 8, 2026 13:51
@harryalbert harryalbert force-pushed the harry/remote-1595-hideshow-specific-chips-when-doing-local-cloud-handoff branch from 22a2aba to b89763b Compare May 8, 2026 14:07
@harryalbert harryalbert force-pushed the graphite-base/10389 branch from cae8721 to ce810f2 Compare May 8, 2026 14:07
@harryalbert harryalbert changed the base branch from graphite-base/10389 to harry/remote-1558-create-entrypoint-for-local-cloud-handoff May 8, 2026 14:07
@harryalbert harryalbert force-pushed the harry/remote-1558-create-entrypoint-for-local-cloud-handoff branch from ce810f2 to 45d3c88 Compare May 8, 2026 14:27
@harryalbert harryalbert force-pushed the harry/remote-1595-hideshow-specific-chips-when-doing-local-cloud-handoff branch from b89763b to 8a36709 Compare May 8, 2026 14:27
@harryalbert harryalbert force-pushed the harry/remote-1558-create-entrypoint-for-local-cloud-handoff branch from 45d3c88 to a783c40 Compare May 8, 2026 16:39
@harryalbert harryalbert force-pushed the harry/remote-1595-hideshow-specific-chips-when-doing-local-cloud-handoff branch from 8a36709 to 2b0c975 Compare May 8, 2026 16:39
@harryalbert harryalbert force-pushed the harry/remote-1558-create-entrypoint-for-local-cloud-handoff branch from a783c40 to ce38e56 Compare May 8, 2026 16:52
@harryalbert harryalbert force-pushed the harry/remote-1595-hideshow-specific-chips-when-doing-local-cloud-handoff branch from 2b0c975 to 086a7df Compare May 8, 2026 16:52
Base automatically changed from harry/remote-1558-create-entrypoint-for-local-cloud-handoff to master May 8, 2026 17:10
@harryalbert harryalbert force-pushed the harry/remote-1595-hideshow-specific-chips-when-doing-local-cloud-handoff branch from 086a7df to b8a955a Compare May 8, 2026 17:17
@harryalbert harryalbert merged commit 8a4df58 into master May 8, 2026
25 checks passed
@harryalbert harryalbert deleted the harry/remote-1595-hideshow-specific-chips-when-doing-local-cloud-handoff branch May 8, 2026 18:29
trungtai1805 pushed a commit to trungtai1805/warp that referenced this pull request May 9, 2026
## Description
<!-- Please remember to add your design buddy onto the PR for review, if
it contains any UI changes! -->

Most of the chips in the agent view input don't make sense when you're
in the `&` input mode. We also want to make the chip transition a little
more pronounced, because when you enter the `&` mode we add in an
environment selector chip that it would be good for people to notice.

For both of these reasons, this PR hides all of the chips in the agent
view input that don't make sense for `&` mode when you're in `&` mode.

## Screenshots / Videos
<!-- Attach screenshots or a short video demonstrating the change, where
appropriate. Remove this section if it is not relevant to your PR. -->

https://www.loom.com/share/df78cd1dade94dce834172ae38d04668

## Agent Mode
- [x] Warp Agent Mode - This PR was created via Warp's AI Agent Mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants