[NEW] tab_config windows maximum height set to window height and scro… by fabiSwDevBeg · Pull Request #13224 · warpdotdev/warp

fabiSwDevBeg · 2026-06-30T12:48:06Z

Description

Makes the new session / tab configs menu height-constrained and scrollable. When users have many tab configs, the menu now caps itself to the available window height instead of extending below the terminal window, and the remaining items can be reached by scrolling.

Linked Issue

Fixes #13223

Testing

I have manually tested my changes locally with ./script/run

Additional automated testing:

./script/format
cargo test -p warp test_new_session_menu_is_scrollable_and_capped_to_window_height
cargo test -p warp tab_configs_menu
cargo run

Changelog Entries for Stable

CHANGELOG-BUG-FIX: Fixed the tab configs menu overflowing past the terminal window when many tab configs are available.

Demo

Attached is a short video demonstrating the proposed behavior and the user experience after this change.

warpdotdev-13224.mp4

…llable

cla-bot · 2026-06-30T12:48:12Z

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @fabiSwDevBeg on file. In order for us to review and merge your code, each contributor must visit https://cla.warp.dev to read and agree to our CLA. Once you have done so, please comment @cla-bot check to trigger another check.

oz-for-oss · 2026-06-30T12:48:16Z

@fabiSwDevBeg

Every PR must be linked to a same-repo issue before Oz can review it.

This PR is linked to #13223, but no linked issue is marked ready-to-implement yet. Only repository maintainers apply that label, so please wait for a maintainer to mark the issue. Once it is marked, push a new commit or comment /oz-review to re-trigger review.

See the contribution guidelines for the full readiness model.

Powered by Oz

oz-for-oss

@fabiSwDevBeg

Every PR must be linked to a same-repo issue before Oz can review it.

This PR is linked to #13223, but no linked issue is marked ready-to-implement yet. Only repository maintainers apply that label, so please wait for a maintainer to mark the issue. Once it is marked, push a new commit or comment /oz-review to re-trigger review.

See the contribution guidelines for the full readiness model.

Powered by Oz

github-actions · 2026-07-07T13:01:02Z

Hi @fabiSwDevBeg — a reviewer requested changes on this PR and it hasn't had activity from you in 7 days. When you get a chance, please push updates or reply to the review so a reviewer can take another look. Without activity, this PR will be automatically closed after 14 days of inactivity.

github-actions · 2026-07-10T12:55:10Z

Hi @fabiSwDevBeg — final reminder: a reviewer requested changes on this PR and it has been inactive for 10 days. It will be automatically closed in about 4 day(s) unless you push updates or reply. Maintainers can apply the no-autoclose label to keep it open.

fabiSwDevBeg · 2026-07-13T10:12:15Z

@cla-bot check

oz-for-oss

@fabiSwDevBeg

Every PR must be linked to a same-repo issue before Oz can review it.

This PR is linked to #13223, but no linked issue is marked ready-to-implement yet. Only repository maintainers apply that label, so please wait for a maintainer to mark the issue. Once it is marked, push a new commit or comment /oz-review to re-trigger review.

See the contribution guidelines for the full readiness model.

Powered by Oz

cla-bot · 2026-07-13T10:12:24Z

The cla-bot has been summoned, and re-checked this pull request!

bholmesdev · 2026-07-14T01:49:11Z

/oz-review

oz-for-oss · 2026-07-14T01:49:29Z

@bholmesdev

I'm re-reviewing this pull request in response to a review request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

oz-for-oss

Overview

This PR makes the new-session/tab configs menu scrollable and caps its height based on the available window height.

Concerns

The new height calculation can still overestimate available space for the vertical-tabs AddTabButton path because rendering anchors from the saved vertical-tabs button position while the keyboard path passes a zero anchor.
This is a user-facing UI behavior change, but the PR description does not include screenshots or a screen recording demonstrating the scrollable capped menu end to end.
No security findings identified in the changed code. No approved spec context was available for spec-alignment review.

Verdict

Found: 0 critical, 2 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

fabiSwDevBeg · 2026-07-14T12:24:45Z

/oz-review

oz-for-oss · 2026-07-14T12:25:04Z

@fabiSwDevBeg

I'm re-reviewing this pull request in response to a review request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

oz-for-oss

Overview

This PR makes the new session / tab configs menu scrollable and caps its height based on the available window space, with a focused unit test for the height calculation.

Concerns

This is a user-facing menu/layout change, but the PR description does not include screenshots or a screen recording demonstrating the menu with many tab configs staying within the window and scrolling end to end. Warp's repo review guidance requires visual evidence for UI-impacting changes, so please attach a screenshot or short recording from a local desktop run or another environment with desktop/computer-use support.

Verdict

Found: 0 critical, 1 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

fabiSwDevBeg · 2026-07-14T12:49:21Z

/oz-review

oz-for-oss · 2026-07-14T12:49:40Z

@fabiSwDevBeg

I'm re-reviewing this pull request in response to a review request.

You can view the conversation on Warp.

I reviewed this pull request and requested human review from: @moirahuang.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Oz no longer requests changes for this pull request after the latest automated review.

oz-for-oss

Overview

This PR makes the new-session / tab configs menu scrollable and caps its height based on the available window space below the menu anchor. It also adds test-only accessors and a regression test for the scrollable, height-constrained menu behavior.

Concerns

No blocking correctness, security, or spec-alignment concerns found in the annotated diff.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

moirahuang · 2026-07-14T18:41:48Z

+        ctx: &ViewContext<Self>,
+    ) -> f32 {
+        let Some(window) = ctx.windows().platform_window(ctx.window_id()) else {
+            return 480.;


let's store these magic values as constants. same with 120 at line 6758

moirahuang · 2026-07-14T20:41:59Z

    }

+    #[cfg(test)]
+    pub fn height(&self) -> f32 {


i think we don't need to add these just for the sake of testing, we can just directly check in the test itself

Extract menu height magic values into named constants and update the height test to assert the Workspace calculation directly instead of adding test-only Menu getters.

fabiSwDevBeg · 2026-07-15T09:20:40Z

/oz-review

oz-for-oss · 2026-07-15T09:21:00Z

@fabiSwDevBeg

I'm re-reviewing this pull request in response to a review request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

oz-for-oss

Overview

This PR makes the new session / tab configs menu scrollable and tries to cap its height to the remaining window space when opened.

Concerns

The computed max height is applied to the menu's scrollable content, but the menu renderer adds vertical padding outside that constrained area, so a full menu can still extend past the bottom of the window.

Verdict

Found: 0 critical, 1 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

oz-for-oss · 2026-07-15T09:25:24Z

+            return NEW_SESSION_MENU_FALLBACK_MAX_HEIGHT;
+        };
+        let anchor_y = self.new_session_menu_height_anchor_y(anchor, ctx);
+        let available_height = window.size().y() - anchor_y - NEW_SESSION_MENU_WINDOW_MARGIN;


⚠️ [IMPORTANT] Menu::set_height caps only the scrollable item area; Menu::render adds MENU_VERTICAL_PADDING above and below that constrained content, so using the full remaining window height here still lets a long menu overflow below the window by the padding/border. Subtract the menu chrome from this available height, or rely on WindowBySize sizing for the positioned menu, so the final rendered menu is actually capped to the window.

…ide the scrollable area, including vertical menu padding and border, so the final rendered dropdown fits within the remaining window height. The test now accounts for that chrome in the expected capped height.

fabiSwDevBeg · 2026-07-15T10:29:37Z

/oz-review

oz-for-oss · 2026-07-15T10:29:57Z

@fabiSwDevBeg

I'm re-reviewing this pull request in response to a review request.

You can view the conversation on Warp.

I reviewed this pull request and requested human review from: @moirahuang.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Oz no longer requests changes for this pull request after the latest automated review.

oz-for-oss

Overview

This PR makes the new-session/tab-configs menu scrollable and caps its height based on the available window space across the existing horizontal, vertical, and pointer-opened menu anchor paths.

Concerns

No blocking correctness, security, or spec-alignment concerns found in the changed lines.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

…13224) With enough tab configs the new-session menu overflowed past the bottom of the window with no way to reach the hidden entries. Compute a max height from the window and anchor position and switch the menu to MenuVariant::scrollable(). Ported from warpdotdev/warp#13224. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

fabiSwDevBeg · 2026-07-24T08:02:13Z

/oz-review

oz-for-oss · 2026-07-24T08:02:33Z

@fabiSwDevBeg

I'm re-reviewing this pull request in response to a review request.

You can view the conversation on Warp.

I reviewed this pull request and requested human review from: @moirahuang.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

oz-for-oss

Overview

This PR makes the new session/tab configs menu scrollable and caps its height based on the available window space, with a focused unit test covering the height calculation. The PR description includes video evidence for the user-facing behavior.

Concerns

No blocking correctness, security, or spec-alignment concerns found in the changed lines.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

[NEW] tab_config windows maximum height set to window height and scro…

8321bb5

…llable

github-actions Bot added the external-contributor Indicates that a PR has been opened by someone outside the Warp team. label Jun 30, 2026

oz-for-oss Bot previously requested changes Jun 30, 2026

View reviewed changes

fabiSwDevBeg marked this pull request as draft July 13, 2026 10:07

fabiSwDevBeg marked this pull request as ready for review July 13, 2026 10:12

cla-bot Bot added the cla-signed label Jul 13, 2026

oz-for-oss Bot previously requested changes Jul 13, 2026

View reviewed changes

fabiSwDevBeg mentioned this pull request Jul 13, 2026

Tab configs menu should be height-constrained and scrollable #13223

Closed

2 tasks

oz-for-oss Bot previously requested changes Jul 14, 2026

View reviewed changes

Comment thread app/src/workspace/view.rs Outdated

Fix vertical tabs new session menu height

fa518d6

oz-for-oss Bot previously requested changes Jul 14, 2026

View reviewed changes

oz-for-oss Bot reviewed Jul 14, 2026

View reviewed changes

oz-for-oss Bot requested a review from moirahuang July 14, 2026 12:53

moirahuang reviewed Jul 14, 2026

View reviewed changes

[FIX] Address review feedback from @moirahuang.

778d895

Extract menu height magic values into named constants and update the height test to assert the Workspace calculation directly instead of adding test-only Menu getters.

oz-for-oss Bot previously requested changes Jul 15, 2026

View reviewed changes

[FIX] Updated the height calculation to subtract the menu chrome outs…

7a672d2

…ide the scrollable area, including vertical menu padding and border, so the final rendered dropdown fits within the remaining window height. The test now accounts for that chrome in the expected capped height.

oz-for-oss Bot reviewed Jul 15, 2026

View reviewed changes

oz-for-oss Bot requested a review from moirahuang July 15, 2026 10:33

moirahuang approved these changes Jul 16, 2026

View reviewed changes

moirahuang enabled auto-merge (squash) July 16, 2026 23:48

moirahuang merged commit 51dae19 into warpdotdev:master Jul 17, 2026
25 checks passed

oz-for-oss Bot reviewed Jul 24, 2026

View reviewed changes

oz-for-oss Bot requested a review from moirahuang July 24, 2026 08:06

Uh oh!

Conversation

fabiSwDevBeg commented Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Linked Issue

Testing

Changelog Entries for Stable

Demo

Uh oh!

cla-bot Bot commented Jun 30, 2026

Uh oh!

oz-for-oss Bot commented Jun 30, 2026

Uh oh!

oz-for-oss Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jul 7, 2026

Uh oh!

github-actions Bot commented Jul 10, 2026

Uh oh!

fabiSwDevBeg commented Jul 13, 2026

Uh oh!

oz-for-oss Bot left a comment

Choose a reason for hiding this comment

Uh oh!

cla-bot Bot commented Jul 13, 2026

Uh oh!

bholmesdev commented Jul 14, 2026

Uh oh!

oz-for-oss Bot commented Jul 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oz-for-oss Bot left a comment

Choose a reason for hiding this comment

Overview

Concerns

Verdict

Uh oh!

Uh oh!

fabiSwDevBeg commented Jul 14, 2026

Uh oh!

oz-for-oss Bot commented Jul 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oz-for-oss Bot left a comment

Choose a reason for hiding this comment

Overview

Concerns

Verdict

Uh oh!

fabiSwDevBeg commented Jul 14, 2026

Uh oh!

oz-for-oss Bot commented Jul 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oz-for-oss Bot left a comment

Choose a reason for hiding this comment

Overview

Concerns

Verdict

Uh oh!

moirahuang Jul 14, 2026

Choose a reason for hiding this comment

Uh oh!

moirahuang Jul 14, 2026

Choose a reason for hiding this comment

Uh oh!

fabiSwDevBeg commented Jul 15, 2026

Uh oh!

oz-for-oss Bot commented Jul 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oz-for-oss Bot left a comment

Choose a reason for hiding this comment

Overview

Concerns

Verdict

Uh oh!

oz-for-oss Bot Jul 15, 2026

fabiSwDevBeg commented Jun 30, 2026 •

edited

Loading

oz-for-oss Bot commented Jul 14, 2026 •

edited

Loading

oz-for-oss Bot commented Jul 14, 2026 •

edited

Loading

oz-for-oss Bot commented Jul 14, 2026 •

edited

Loading

oz-for-oss Bot commented Jul 15, 2026 •

edited

Loading

oz-for-oss Bot commented Jul 15, 2026 •

edited

Loading

oz-for-oss Bot commented Jul 24, 2026 •

edited

Loading