Add idle TUI footer navigation hints#13748
Draft
warp-dev-github-integration[bot] wants to merge 1 commit into
Draft
Add idle TUI footer navigation hints#13748warp-dev-github-integration[bot] wants to merge 1 commit into
warp-dev-github-integration[bot] wants to merge 1 commit into
Conversation
- Add render_idle_navigation_hint() as a method on TuiUiBuilder
alongside the other semantic styling helpers, so the logic and
its test live in tui_builder{,_tests}.rs rather than in
terminal_session_view{,_tests}.rs
- Add key_hint_style() using the theme's bright.blue terminal color
instead of a hardcoded RGB value, so it adapts to custom themes
- Show the hint (↑ to edit Esc to stop ← for conversations) in
the footer when a completed exchange is available
- Test in tui_builder_tests.rs: renders correct text and correct
per-span colors
Co-Authored-By: Oz <oz-agent@warp.dev>
warp-dev-github-integration
Bot
force-pushed
the
tui-verify/CODE-1852-footer-idle-navigation-hints
branch
from
July 15, 2026 14:12
4245f95 to
c7b3109
Compare
Contributor
Author
|
Addressed all three points of feedback:
|
ErshovDmitry
added a commit
to ErshovDmitry/warp-i18n
that referenced
this pull request
Jul 16, 2026
… resolve 3 conflicts Merge origin/master into i18n (downstream sync; keeps i18n SHA stable for stacked PR warpdotdev#13374). 3 content conflicts resolved per SOP merge-pattern (upstream structural refactor wins; restore menu_label wraps at call sites): - app/src/ai/blocklist/inline_action/orchestration_controls.rs (16 hunks): 15 wraps preserved - crates/warp_tui/src/terminal_session_view.rs (1 hunk): 29 wraps preserved - crates/warp_tui/src/zero_state.rs (1 hunk): 12 wraps preserved Auto-merged i18n files retained wraps: terminal/view.rs(99), agent_management/view.rs(50), lib.rs(22), tui_export(1), warp_tui/slash_commands(3), agent_block_sections(4). Known follow-up (tracked): upstream extracted orchestration UI into new module app/src/ai/orchestration/ (snapshots/validation/providers/config_state) with raw English literals — ~16 wrap sites regressed. Restore as next wave. New unwrapped literals for future wave: zero_state MCP section ("MCP", status labels), terminal_session_view "ctrl-c again to exit", orchestration "Loading…"/"No harnesses available". Gate: cargo check -p warp OK (5 upstream warnings in mcp/, not i18n scope); cargo test -p i18n 12/12 passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add idle-state footer navigation hints after the current conversation has at least one completed exchange. Key labels use the Figma
#D0D1FEcolor through a semantic TUI builder style, while action labels use the muted text style.Fixes CODE-1852
Linked Issue
https://linear.app/warpdotdev/issue/CODE-1852/tui-verify-footer-navigation-hints-missing-in-idle-state
ready-to-specorready-to-implement.Testing
cargo nextest run -p warp_tui -E 'test(idle_footer_navigation_hint_renders_key_and_action_text)'env -u WARP_API_KEY cargo nextest run -p warp_tui --no-fail-fast— 203 passedcargo nextest run -p warpui_core --no-fail-fast— 310 passed, 7 skippedcargo build --release -p warp_tui --bin warp-tui-dev./script/formatcargo clippy --workspace --exclude warp_completer --all-targets --tests -- -D warningscargo clippy -p warp_completer --all-targets --tests -- -D warningsI manually tested the release
warp-tui-devbinary under tmux.TUI verification
Before, after one completed exchange, the left footer slot was empty:
After, the completed-exchange idle footer contains the full navigation hint:
A separate fresh zero-state capture contains no navigation hint. The ANSI capture reports
38;2;208;209;254mfor each key span and muted38;2;157;157;157mfor each action span.Agent Mode
CHANGELOG-BUG-FIX: Added missing navigation hints to the TUI footer after completed conversations.
Conversation: https://staging.warp.dev/conversation/29de3017-5e54-4f8f-bf25-61cb765b567d
Run: https://oz.staging.warp.dev/runs/019f62f3-4834-76e5-ac87-d0188519a0c5
Co-Authored-By: Oz oz-agent@warp.dev
This PR was generated with Oz.