Promote CloudRunners and CloudAgentRunners to stable#14010
Conversation
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
- Add 'cloud_runners' and 'cloud_agent_runners' to default features in app/Cargo.toml - Add cloud_agent_runners Cargo feature definition in app/Cargo.toml - Add #[cfg(feature = "cloud_agent_runners")] bridge entry in app/src/features.rs - Remove CloudRunners and CloudAgentRunners from DOGFOOD_FLAGS in warp_features/src/lib.rs Co-Authored-By: Oz <oz-agent@warp.dev>
986dda6 to
2880fe0
Compare
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR promotes CloudRunners and CloudAgentRunners to stable by enabling their Cargo features by default, wiring CloudAgentRunners into the app feature bridge, removing both flags from dogfood-only runtime defaults, and applying clippy-only completer refactors. No approved spec context was provided, and I did not find separate security concerns in the diff.
Concerns
- The change exposes runner-related UI and CLI behavior to all stable users, but the PR does not include screenshots or a screen recording demonstrating the user-facing flows end to end, and the manual-test checkbox is unchecked.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
| "cloud_runners", | ||
| "cloud_agent_runners", |
There was a problem hiding this comment.
2 participants
Description
Promotes
CloudRunnersandCloudAgentRunnersfeature flags to stable so they are enabled for all Warp users, not just dogfood builds.Changes:
app/Cargo.toml: Addedcloud_runnersandcloud_agent_runnersto thedefaultfeatures array; addedcloud_agent_runners = []feature definitionapp/src/features.rs: Added#[cfg(feature = "cloud_agent_runners")] FeatureFlag::CloudAgentRunnersbridge entrycrates/warp_features/src/lib.rs: RemovedCloudRunnersandCloudAgentRunnersfromDOGFOOD_FLAGS(they're now indefault)Also fixes pre-existing clippy lints in
warp_completer/src/completer/engine/argument/v2.rs(collapsible-if and let-and-return warnings) that were blocking the presubmit check.Linked Issue
N/A
Testing
./script/format,cargo clippyper./script/presubmit)./script/runAgent Mode
Conversation: https://staging.warp.dev/conversation/6bdfbd6d-ecc3-4633-8336-fb6d400ff3ee
Run: https://oz.staging.warp.dev/runs/019f7ffb-bded-715b-a1be-5664801bbd44
This PR was generated with Oz.