Skip to content

add TUI file-edit permission requests#14020

Merged
harryalbert merged 2 commits into
masterfrom
harry/code-1809-file-edit-permissions
Jul 21, 2026
Merged

add TUI file-edit permission requests#14020
harryalbert merged 2 commits into
masterfrom
harry/code-1809-file-edit-permissions

Conversation

@harryalbert

@harryalbert harryalbert commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Description

This PR implements permissions requests for file edits. The UI is pretty much the same as the PR below this one, but we show the actual file edits in the permissions card. These file edits are collapsed by default (so the card is small and readable instead of very large for large edits), and each edit is expandable.

Testing

  • I have manually tested my changes locally with ./script/run

Screenshots / Videos

https://www.loom.com/share/82bcaeef4bb54a668a1173599c6c8f6b

Agent Mode

  • Warp Agent Mode - This PR was created via Warp's AI Agent Mode

@cla-bot cla-bot Bot added the cla-signed label Jul 20, 2026

harryalbert commented Jul 20, 2026

Copy link
Copy Markdown
Contributor Author

@harryalbert
harryalbert force-pushed the harry/code-1809-implement-permissions-requests-ui-for-tool-calls branch from 2e408b3 to 0402b3e Compare July 20, 2026 18:57
@harryalbert
harryalbert force-pushed the harry/code-1809-file-edit-permissions branch 2 times, most recently from 0665878 to 46aea00 Compare July 20, 2026 19:21
@harryalbert
harryalbert force-pushed the harry/code-1809-implement-permissions-requests-ui-for-tool-calls branch from 0402b3e to 17f0a50 Compare July 20, 2026 19:21
@harryalbert
harryalbert requested a review from ianhodge July 20, 2026 20:42
@harryalbert
harryalbert marked this pull request as ready for review July 20, 2026 20:57
@oz-for-oss

oz-for-oss Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

@harryalbert

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@oz-for-oss oz-for-oss Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR adds TUI permission handling for file-edit tool calls by wrapping blocked file-edit diffs in the shared permission prompt, routing accept/reject/replacement-guidance events back through the action model, and defaulting diff sections to collapsed with focused unit coverage.

Concerns

  • No blocking correctness, security, or spec-alignment concerns were found in the annotated diff.
  • No approved or repository spec context was provided for this PR, so there was no material spec drift to flag.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@harryalbert
harryalbert force-pushed the harry/code-1809-implement-permissions-requests-ui-for-tool-calls branch from 17f0a50 to c455672 Compare July 20, 2026 23:56
@harryalbert
harryalbert force-pushed the harry/code-1809-file-edit-permissions branch 2 times, most recently from 810ff18 to d86e2e5 Compare July 21, 2026 00:36
@harryalbert
harryalbert force-pushed the harry/code-1809-implement-permissions-requests-ui-for-tool-calls branch from c455672 to f2992eb Compare July 21, 2026 00:36
@harryalbert
harryalbert force-pushed the harry/code-1809-file-edit-permissions branch from d86e2e5 to bd793a1 Compare July 21, 2026 00:59
Base automatically changed from harry/code-1809-implement-permissions-requests-ui-for-tool-calls to master July 21, 2026 01:23
harryalbert and others added 2 commits July 20, 2026 21:23
@harryalbert
harryalbert force-pushed the harry/code-1809-file-edit-permissions branch from bd793a1 to e455801 Compare July 21, 2026 01:23
@harryalbert
harryalbert merged commit 1d70a32 into master Jul 21, 2026
26 checks passed
@harryalbert
harryalbert deleted the harry/code-1809-file-edit-permissions branch July 21, 2026 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants