Demote next command suggestion reporting to log::error - #14289
Conversation
Co-Authored-By: Oz <oz-agent@warp.dev>
|
@warp-dev-github-integration[bot] I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR demotes failed Next Command suggestion reporting from report_error! to an error-level log breadcrumb and removes the now-unused report_error import.
Concerns
- No blocking correctness, security, or spec-alignment concerns found in the changed lines.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
There was a problem hiding this comment.
Overview
This PR implements the requested severity demotion for failed Next Command suggestions: it replaces the non-actionable Sentry report with an error-level log breadcrumb and removes the unused import, with no unrelated changes.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Review run
https://oz.staging.warp.dev/runs/019f96c3-c5cc-750e-ad0e-f0d134a1d9b5
Description
Demote the failed Next Command suggestion Sentry report to a local
log::error!breadcrumb. This prevents the external HTTP 403 from creating a high-volume non-actionable Sentry issue while retaining the error chain in local diagnostics. The now-unusedwarp_errors::report_errorimport is removed.Linked Issue
APP-4984: https://linear.app/warpdotdev/issue/APP-4984/warp-demote-failed-to-generate-next-command-suggestion-sentry-error-to
Sentry issue: https://warpdotdev.sentry.io/issues/6241197991
Testing
This is a testing-exempt logging-severity change: the requested behavior is the sink/macro choice itself, and adding a test would only assert the literal log call rather than exercise meaningful behavior. No comments or tests were added, per the requester.
Passed independently:
./script/format --check./script/check_no_inline_test_modules./script/run-clang-format.py -r --extensions 'c,h,cpp,m' ./crates/warpui/src/ ./app/src/find . -name '*.wgsl' -exec wgslfmt --check {} +./script/presubmitand focused low-memory clippy/check attempts reached the Warp library compilation step but were terminated by the 4 GiB environment with SIGKILL (signal 9); no compiler or clippy diagnostic was emitted. The source diff remains format-clean and limited to the requested logging/import change.Originating thread: https://warpdev.slack.com/archives/C0BDQDW8V5E/p1784937248857449?thread_ts=1784937248.857449&cid=C0BDQDW8V5E
Conversation: https://staging.warp.dev/conversation/c608340b-69e7-4cfd-b0b2-c6c049136ac9
Run: https://oz.staging.warp.dev/runs/019f969a-a3db-7a75-9e37-9d50427af363
This PR was generated with Oz.
Co-Authored-By: Oz oz-agent@warp.dev