TUI: add inline /api-keys menu - #14472
Merged
harryalbert merged 1 commit intoJul 30, 2026
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
harryalbert
force-pushed
the
harry/code-1930-tui-replace-byok-slash-commands-with-a-keys-inline-menu
branch
from
July 29, 2026 19:40
463f287 to
13b1395
Compare
harryalbert
force-pushed
the
graphite-base/14472
branch
from
July 29, 2026 19:40
0835276 to
77cd93f
Compare
harryalbert
changed the base branch from
graphite-base/14472
to
harry/tui-inline-menu-input-ownership
July 29, 2026 19:40
2 tasks
harryalbert
changed the title
harryalbert
force-pushed
the
harry/tui-inline-menu-input-ownership
branch
from
July 29, 2026 19:57
77cd93f to
d13469b
Compare
harryalbert
force-pushed
the
harry/code-1930-tui-replace-byok-slash-commands-with-a-keys-inline-menu
branch
from
July 29, 2026 19:57
13b1395 to
7b77da4
Compare
harryalbert
marked this pull request as ready for review
July 29, 2026 20:32
Contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Overview
This PR replaces the TUI-only provider-key slash commands with an inline /api-keys menu, adds the API-key menu state machine, integrates it with the shared TUI inline-menu/input ownership system, and refactors Grok OAuth into a controller used by the menu. The attached description includes a Loom demo, satisfying the TUI visual-evidence requirement.
Concerns
- No blocking correctness, security, or spec-alignment concerns found in the annotated diff.
spec_context.mddid not contain approved or repository spec context, so there were no external spec commitments to validate against.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
harryalbert
force-pushed
the
harry/code-1930-tui-replace-byok-slash-commands-with-a-keys-inline-menu
branch
from
July 29, 2026 21:25
7b77da4 to
856e6df
Compare
harryalbert
force-pushed
the
harry/tui-inline-menu-input-ownership
branch
from
July 29, 2026 21:25
d13469b to
92a009d
Compare
harryalbert
force-pushed
the
harry/tui-inline-menu-input-ownership
branch
from
July 29, 2026 22:00
92a009d to
97a55e2
Compare
harryalbert
force-pushed
the
harry/code-1930-tui-replace-byok-slash-commands-with-a-keys-inline-menu
branch
2 times, most recently
from
July 29, 2026 23:00
87f65c6 to
66fed8f
Compare
harryalbert
force-pushed
the
harry/tui-inline-menu-input-ownership
branch
from
July 29, 2026 23:00
97a55e2 to
f2db220
Compare
moirahuang
approved these changes
Jul 30, 2026
harryalbert
force-pushed
the
harry/code-1930-tui-replace-byok-slash-commands-with-a-keys-inline-menu
branch
from
July 30, 2026 13:30
66fed8f to
de896e2
Compare
harryalbert
force-pushed
the
harry/tui-inline-menu-input-ownership
branch
from
July 30, 2026 13:30
f2db220 to
8f81c46
Compare
Co-Authored-By: Oz <oz-agent@warp.dev>
harryalbert
force-pushed
the
harry/code-1930-tui-replace-byok-slash-commands-with-a-keys-inline-menu
branch
from
July 30, 2026 14:00
de896e2 to
2c10ef7
Compare
harryalbert
deleted the
harry/code-1930-tui-replace-byok-slash-commands-with-a-keys-inline-menu
branch
July 30, 2026 14:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces the TUI-only
/add-api-keyand/clear-provider-api-keycommands with a single inline/api-keysmenu.The menu supports filtering providers, setting and clearing provider keys, connecting or disconnecting X Premium/SuperGrok, and toggling Warp-credit fallback. It reuses the shared TUI editor through the ownership model reviewed separately in downstack PR #14488.
This is a pretty large change, but the large majority of it is UI changes. Reading the specs should be enough for this one (I'll also attach an in depth demo of the change below).
Testing
./script/runScreenshots/Video
https://www.loom.com/share/853ce5b6278840c89ced6bfde7b53820
Agent Mode
Co-Authored-By: Oz oz-agent@warp.dev