fix input scroll issues - #14597
Merged
Merged
Conversation
harryalbert
marked this pull request as ready for review
July 31, 2026 17:25
Contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
kevinyang372
approved these changes
Jul 31, 2026
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Overview
This PR adjusts the Warp TUI input composer row limit so all six editor rows can render when the bordered input chrome is present, and adds a regression test for the six-row case.
Concerns
- This is a user-facing TUI behavior change, but the PR description does not include accepted visual evidence such as a terminal transcript,
render_to_lines/TuiBuffer::to_linessnapshot diff, or./script/run-tuicapture demonstrating the scroll/input rendering behavior end to end. Please attach one of those TUI-appropriate artifacts before merge.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Input scrolling was messed up because our calculation for the size of the input was wrong. This fixes that.
Testing
./script/runAgent Mode