Make TUI voice input optional on Linux - #14611
Merged
Merged
Conversation
Contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
Contributor
There was a problem hiding this comment.
Overview
This PR makes TUI voice input an opt-in warp_tui feature, omits it from Linux portable bundles, keeps it enabled for macOS/Windows bundles, and adds a disabled fallback module plus feature-gated tests.
Concerns
- Missing TUI behavioral evidence for a user-facing change. The PR body has no testing notes or TUI transcript/render snapshot/
./script/run-tuicapture showing the disabled Linux path and the enabled macOS/Windows/local-dev path. For this TUI-facing change, please attach terminal evidence demonstrating the voice statusline/keybinding behavior end to end.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
kevinyang372
force-pushed
the
fix-tui-linux-alsa-dependency
branch
from
July 31, 2026 23:08
beca268 to
c8b836d
Compare
moirahuang
approved these changes
Aug 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Makes Warp Agent CLI voice input an explicit
warp_tui/voice_inputfeature instead of enabling it through every TUI build.Linux TUI release bundles deliberately omit the feature, removing the unconditional CPAL → ALSA dependency that prevented the binary from starting on minimal Linux environments without
libasound.so.2. macOS and Windows bundles explicitly retain voice input through their native audio backends.No-voice builds now compile the TUI voice integration out entirely rather than substituting a disabled placeholder model. They do not construct or subscribe to a voice model, register voice actions or bindings, enable modifier-key reporting, or render voice input controls. The GUI
guifeature continues to enable voice input and is unchanged.Linked Issue
User-reported Warp Agent CLI preview regression; no issue filed.
Testing
./script/formatcargo clippy --workspace --exclude warp_completer --all-targets --tests -- -D warningscargo clippy -p warp --all-targets --tests -- -D warningscargo clippy -p warp_completer --all-targets --tests -- -D warningscargo check -p warp_tuicargo check -p warp_tui --features voice_inputcargo test -p warp_tui --no-runcargo test -p warp_tui --features voice_input --no-runcargo nextest run -p warp_tui— 936 passedcargo nextest run -p warp_tui --features voice_input— 955 passedcargo clippy -p warp_tui --all-targets -- -D warningscargo clippy -p warp_tui --all-targets --features voice_input -- -D warningscargo tree: default TUI has noalsapackage;--features voice_inputrestoreswarp_tui → warp → voice_input → cpal → alsaA Linux bundle was not run end-to-end from this macOS host; the Linux-target dependency graph verifies that the startup dependency is absent.
./script/runAgent Mode
CHANGELOG-BUG-FIX: Fixed Warp Agent CLI failing to launch on minimal Linux systems without ALSA installed.
CHANGELOG-TUI: Fixed Warp Agent CLI failing to launch on minimal Linux systems without ALSA installed.