Skip to content

Make TUI voice input optional on Linux - #14611

Merged
kevinyang372 merged 1 commit into
masterfrom
fix-tui-linux-alsa-dependency
Aug 1, 2026
Merged

Make TUI voice input optional on Linux#14611
kevinyang372 merged 1 commit into
masterfrom
fix-tui-linux-alsa-dependency

Conversation

@kevinyang372

@kevinyang372 kevinyang372 commented Jul 31, 2026

Copy link
Copy Markdown
Member

Description

Makes Warp Agent CLI voice input an explicit warp_tui/voice_input feature instead of enabling it through every TUI build.

Linux TUI release bundles deliberately omit the feature, removing the unconditional CPAL → ALSA dependency that prevented the binary from starting on minimal Linux environments without libasound.so.2. macOS and Windows bundles explicitly retain voice input through their native audio backends.

No-voice builds now compile the TUI voice integration out entirely rather than substituting a disabled placeholder model. They do not construct or subscribe to a voice model, register voice actions or bindings, enable modifier-key reporting, or render voice input controls. The GUI gui feature continues to enable voice input and is unchanged.

Linked Issue

User-reported Warp Agent CLI preview regression; no issue filed.

Testing

  • ./script/format
  • cargo clippy --workspace --exclude warp_completer --all-targets --tests -- -D warnings
  • cargo clippy -p warp --all-targets --tests -- -D warnings
  • cargo clippy -p warp_completer --all-targets --tests -- -D warnings
  • cargo check -p warp_tui
  • cargo check -p warp_tui --features voice_input
  • cargo test -p warp_tui --no-run
  • cargo test -p warp_tui --features voice_input --no-run
  • cargo nextest run -p warp_tui — 936 passed
  • cargo nextest run -p warp_tui --features voice_input — 955 passed
  • cargo clippy -p warp_tui --all-targets -- -D warnings
  • cargo clippy -p warp_tui --all-targets --features voice_input -- -D warnings
  • Linux cargo tree: default TUI has no alsa package; --features voice_input restores warp_tui → warp → voice_input → cpal → alsa
  • Shell syntax validation for the modified Linux/macOS bundle and local TUI scripts

A Linux bundle was not run end-to-end from this macOS host; the Linux-target dependency graph verifies that the startup dependency is absent.

  • I have manually tested my changes locally with ./script/run

Agent Mode

CHANGELOG-BUG-FIX: Fixed Warp Agent CLI failing to launch on minimal Linux systems without ALSA installed.
CHANGELOG-TUI: Fixed Warp Agent CLI failing to launch on minimal Linux systems without ALSA installed.

@cla-bot cla-bot Bot added the cla-signed label Jul 31, 2026
@oz-for-oss

oz-for-oss Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

@kevinyang372

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@oz-for-oss oz-for-oss Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR makes TUI voice input an opt-in warp_tui feature, omits it from Linux portable bundles, keeps it enabled for macOS/Windows bundles, and adds a disabled fallback module plus feature-gated tests.

Concerns

  • Missing TUI behavioral evidence for a user-facing change. The PR body has no testing notes or TUI transcript/render snapshot/./script/run-tui capture showing the disabled Linux path and the enabled macOS/Windows/local-dev path. For this TUI-facing change, please attach terminal evidence demonstrating the voice statusline/keybinding behavior end to end.

Verdict

Found: 0 critical, 1 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@kevinyang372
kevinyang372 force-pushed the fix-tui-linux-alsa-dependency branch from beca268 to c8b836d Compare July 31, 2026 23:08
@kevinyang372
kevinyang372 requested a review from moirahuang July 31, 2026 23:11
@kevinyang372
kevinyang372 merged commit 7cbb22d into master Aug 1, 2026
48 of 50 checks passed
@kevinyang372
kevinyang372 deleted the fix-tui-linux-alsa-dependency branch August 1, 2026 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants