Skip to content

Fix TUI zero-state onboarding flicker - #14612

Merged
kevinyang372 merged 1 commit into
masterfrom
kevin/fix-tui-zero-state-onboarding-flicker
Aug 1, 2026
Merged

Fix TUI zero-state onboarding flicker#14612
kevinyang372 merged 1 commit into
masterfrom
kevin/fix-tui-zero-state-onboarding-flicker

Conversation

@kevinyang372

@kevinyang372 kevinyang372 commented Jul 31, 2026

Copy link
Copy Markdown
Member

Description

Prevent returning Warp Agent CLI users from briefly seeing the first-run “What’s different about Warp” content while account-scoped onboarding markers load.

The session now tracks the first zero state as pending, visible, or dismissed. Pending markers render the standard project context and MCP zero state; the first-run content becomes visible only after the persisted marker confirms it is still available. User interaction while loading also prevents a late first-run reveal.

Linked Issue

Reported directly during TUI testing; no matching Linear or GitHub issue.

Testing

  • ./script/format

  • cargo clippy --workspace --exclude warp_completer --all-targets --tests -- -D warnings

  • cargo clippy -p warp --all-targets --tests -- -D warnings

  • cargo clippy -p warp_completer --all-targets --tests -- -D warnings

  • env -u WARP_API_KEY cargo nextest run -p warp_tui (963 passed)

  • Live warp-tui-oss startup verification under tmux with inherited authentication

  • Polled 80 startup frames at 250 ms intervals: the standard zero state appeared and the first-run copy appeared in zero frames

  • I have manually tested my changes locally with the Warp TUI

Agent Mode

CHANGELOG-TUI: Fixed first-run onboarding content briefly appearing during startup for returning users.

Co-Authored-By: Warp agent@warp.dev

Co-Authored-By: Warp <agent@warp.dev>
@cla-bot cla-bot Bot added the cla-signed label Jul 31, 2026

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@kevinyang372
kevinyang372 marked this pull request as ready for review July 31, 2026 22:43
@kevinyang372
kevinyang372 requested a review from moirahuang July 31, 2026 22:43
@oz-for-oss

oz-for-oss Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

@kevinyang372

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@oz-for-oss oz-for-oss Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR changes the TUI first-zero-state flow from a boolean into pending/visible/dismissed states so returning users see the standard zero state while account-scoped onboarding markers load. The implementation and updated tests did not surface a line-mappable correctness, security, or spec-drift issue in the attached diff.

Concerns

  • This is a user-facing TUI behavior change, but the PR does not attach acceptable TUI visual evidence. The description lists manual tmux verification and frame polling, but repo guidance requires a terminal transcript, render_to_lines / TuiBuffer::to_lines snapshot diff, or ./script/run-tui capture demonstrating the behavior end to end.

Verdict

Found: 0 critical, 1 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@kevinyang372
kevinyang372 merged commit 49e9e2f into master Aug 1, 2026
51 checks passed
@kevinyang372
kevinyang372 deleted the kevin/fix-tui-zero-state-onboarding-flicker branch August 1, 2026 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants