Skip to content

Keep TUI zero state stable during shell startup - #14632

Merged
moirahuang merged 1 commit into
masterfrom
factory/app-5098-stabilize-tui-zero-state
Aug 3, 2026
Merged

Keep TUI zero state stable during shell startup#14632
moirahuang merged 1 commit into
masterfrom
factory/app-5098-stabilize-tui-zero-state

Conversation

@warp-agent-staging

@warp-agent-staging warp-agent-staging Bot commented Aug 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

  • Keep the empty TUI zero state vertically stable while the temporary Starting shell... hint is visible.
  • Account for the hint row and its top padding only in the bootstrap zero-state slot; transcript, long-running-command, and GUI paths remain unchanged.
  • Add a presenter-based 80×40 regression covering bootstrap and ready states.

Originating thread: https://warpdotdev.slack.com/archives/C0BDQDW8V5E/p1785652323329829

Linked Issue

  • The request is tracked in APP-5098.
  • Real live-TUI tmux capture-pane proof is included below.

Testing

  • zero_state_position_stays_stable_across_shell_bootstrap failed before the fix and passes after it.
  • bootstrap_renders_starting_shell_above_input and long_running_command_keeps_input_hidden pass.
  • ./script/format --check
  • cargo clippy -p warp_tui --all-targets --tests -- -D warnings
  • cargo nextest run -p warp_tui --lib — 949/949 passed.
  • cargo build -p warp_tui --bin warp-tui-oss
  • cargo build -p warp_tui --bin warp-tui-dev

Full workspace presubmit completed format, inline-test, clippy, clang-format, and WGSL checks, but its workspace-test phase exceeded the sandbox target filesystem twice (No space left on device); the scoped TUI suite and PR CI are fully green.

Real live TUI proof

These frames came directly from tmux capture-pane while one authenticated warp-tui-dev process ran in an 80×40 PTY. They are terminal output from the real TUI, not replayed presenter buffers.

Relevant lines (one-based capture-pane output; equivalent zero-based rows are 13/32/33):

bootstrap  14: Warp Agent CLI
bootstrap  33: Starting shell...
bootstrap  34: ▁▁▁...  (input top border)
ready      14: Warp Agent CLI
ready      34: ▁▁▁...  (input top border)

Agent Mode

  • Warp Agent Mode - This PR was created via Warp's AI Agent Mode

CHANGELOG-TUI: Fixed the zero state shifting when shell startup completes.

Rework changes

  • ⚠️ Real TUI proof: installed the pinned internal channel-config generator, built the dev/dogfood TUI, authenticated with the inherited cloud-runner API key, and captured bootstrap plus ready frames from the same live tmux session. The title and input border remain on identical rows while Starting shell... disappears.
  • No code changes were needed; the review finding concerned verification evidence only.

Conversation: https://staging.warp.dev/conversation/5020fa91-cade-4b17-8d57-af8c5de70f0c
Run: https://oz.staging.warp.dev/runs/019fc139-4de5-70c1-a4ef-4a772853163a

Co-Authored-By: Oz oz-agent@warp.dev
This PR was generated with Oz.

@oz-agent
Keep the TUI zero state stable during shell startup
a891b5b 
Co-Authored-By: Oz <oz-agent@warp.dev>
@cla-bot cla-bot Bot added the cla-signed label Aug 2, 2026
@warp-agent-staging
warp-agent-staging Bot requested a review from moirahuang August 2, 2026 08:15
@warp-agent-staging
warp-agent-staging Bot marked this pull request as ready for review August 2, 2026 08:15
@moirahuang
moirahuang merged commit 956ae6b into master Aug 3, 2026
59 checks passed
@moirahuang
moirahuang deleted the factory/app-5098-stabilize-tui-zero-state branch August 3, 2026 07:32
mehmetbaykar added a commit to mehmetbaykar/zap that referenced this pull request Aug 3, 2026
@mehmetbaykar @claude
merge: upstream 2b4a66f..956ae6b (3 commits, all stripped)
c929a3c 
Ancestry-only merge: `-s ours`, so the tree is byte-identical to the previous
commit and no upstream content is taken. This advances the merge-base to
956ae6b so the next real merge starts from a tight base.

All three commits are strips under the fork's standing policy:

  89af536  Gate TUI cost footer credits/dollars toggle behind
             TuiCostTransparency (warpdotdev#14640) - entirely crates/warp_tui, which this
             fork deleted (keep-deleted strip-list). Its warp_features flag would
             be dead code here.

  41f91c6  [REV-1714] Use server-authoritative AI credit availability in the
             client (warpdotdev#14634) - cloud billing surface: new
             app/src/ai/credit_availability.rs, GraphQL get_ai_credit_availability
             + schema.graphql, and app/src/terminal/buy_credits_banner.rs /
             crates/graphql/src/api/ai.rs, neither of which exists in this fork.
             It also rewires app/src/ai/request_usage_model.rs, which is the
             fork's always-unlimited local stub and stays ours.

  956ae6b  Keep TUI zero state stable during shell startup (warpdotdev#14632) - entirely
             crates/warp_tui.

Gates were not re-run: the tree is unchanged from the parent, so they are
provably identical (same reasoning as slice 3 of the 2026-08-01 wave).

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@moirahuang moirahuang moirahuang approved these changes

Assignees

No one assigned

Labels

cla-signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@moirahuang @oz-agent