Advance onboarding on a post-checkout return (REV-1952)

[warp-agent-staging]

Description

During account-first onboarding, picking the Warp plan option on the "Choose how to start" offer opens /upgrade in the browser. If the user changes their mind on the web and buys a one-time credit pack instead, the confirmation page returns them through warp://settings/billing_and_usage. That deeplink is gated on AuthOnboardingState::Terminal, so mid-onboarding it only produced:

[ERROR] Auth not complete before trying to open settings page [section=BillingAndUsage]

and onboarding never left the offer slide. Nothing else picked the purchase up either: the offer's completion path required a client-recorded CreditPurchaseState::AwaitingCheckout, which only the in-client pack CTA sets, and the app-focus refresh never re-read AI credit availability at all.

This is the client half of REV-1952. The web half (making the add-on confirmation card hand off through computeAppLaunchUrl with checkoutSuccessful=true) ships separately in warpdotdev/warp-server; the two PRs share that exact param name and value.

What changed

• checkoutSuccessful=true convention (app/src/uri/mod.rs). url_reports_checkout_success recognises the flag on any incoming deeplink, and RootView::handle_incoming_auth_url routes it into onboarding so the desktop hand-off advances the AI-sell stage rather than only re-initialising auth.
• The swallowed intent no longer errors (app/src/root_view.rs). A Billing & Usage deeplink arriving while onboarding is non-Terminal is read as the same post-checkout return and advances the flow. Outside onboarding the deeplink still opens Billing & Usage exactly as before, and any other section arriving non-Terminal still reports the original error.
• Simplified completion rule (crates/onboarding/src/model.rs). The offer completes on any observation that the user can now make an AI request — plan or pack, bought in the client or on the web — instead of tracking which purchase the client started. The head-start offer is deliberately excluded: it ships with AI usage already on the account, so availability says nothing about the user's choice there.
• Focus fallback actually works (app/src/root_view.rs). AppBecameActive and AuthComplete now share one refresh_onboarding_account_state, which adds the AI-credit-availability refresh the focus path was missing. That single check is what the offer advances off, so a user who ignores the intent link and just refocuses the app is let through.
• Onboarding context on outbound links is unchanged: AuthManager::upgrade_url() already appends state, which is what the confirmation page keys its onboarding detection off, and it backs every onboarding surface that opens the web upgrade page.

Linked Issue

REV-1952 — labeled triage-done (the requester declined a written spec, so the ticket's Acceptance Criteria are the contract).

Testing

Regression tests added, each verified to fail before the change and pass after:

• onboarding model::tests::credit_availability_advances_the_offer_without_a_pending_checkout — the exact reported path (left through the plan CTA, bought a pack on the web, no client-side checkout recorded). Confirmed failing against the old AwaitingCheckout gate.
• onboarding model::tests::the_checkout_success_handoff_advances_the_ai_sell_offer
• onboarding model::tests::the_checkout_success_handoff_is_inert_outside_an_ai_sell_offer — covers the head-start offer and pre-offer slides.
• warp uri::tests::test_url_reports_checkout_success — only an explicit true counts, and the flag is recognised on both the auth and settings hosts.

Commands run from the repo root:

• ./script/format — clean.

• cargo clippy -p onboarding -p warp --all-targets --tests -- -D warnings — clean.

• cargo nextest run -p onboarding --no-fail-fast — 52 passed, 0 failed.

• cargo nextest run -p warp -E 'test(uri::) or test(root_view)' — 78 passed, 0 failed.

• I have manually tested my changes locally with ./script/run

Screenshots / Videos

The fixed path itself is not visually verified — treat that proof as outstanding. Reaching the "Choose how to start" offer requires a brand-new authenticated account, and exercising the crossover additionally requires a live Stripe checkout plus the paired warpdotdev/warp-server change. None of those are available in this environment, so a human should confirm the rendered behaviour: new account → offer slide → Warp plan → buy a pack on the web → return to the app → onboarding advances with no auth error in the logs.

What the recording below does show is a smoke test of the surrounding flow on a Linux build of this branch: the app launches and the first-run onboarding renders and navigates ("Welcome to Warp" → "Customize your Warp" → "Choose a theme" → "Create an account"), with no crash, hang, or error output beyond two benign libEGL ... DRI3 warnings. Advancing stops at the account screen, which is exactly where the unreachable post-auth offer would follow.

Computer-use video recordings

View video recording - Warp onboarding walkthrough: Walking forward through the Warp first-run onboarding screens starting from "Welcome to Warp" until reaching the sign-in screen, then closing the app.

Computer-use screenshots (4)

View screenshot - Onboarding screen 1: "Welcome to Warp" with a "Get started" button and "Already have an account? Log in" link.

View screenshot - Onboarding screen 2: "Customize your Warp" with cards Tab styling/Vertical, Tools panel, Code review/Enabled, and a Next button.

View screenshot - Onboarding screen 3: "Choose a theme" with theme cards Phenomenon, Dark (selected), Light, Adeberry, and a "Sync light/dark theme with OS" checkbox.

View screenshot - Onboarding screen 4: "Create an account" with a "Use a work email to find teammates" card, Privacy Settings/Terms of Service links, and Skip/Continue buttons — the sign-in screen.

Agent Mode

• Warp Agent Mode - This PR was created via Warp's AI Agent Mode

CHANGELOG-BUG-FIX: Onboarding now continues past the AI offer after you buy credits or a plan on the web, instead of getting stuck.

Originating thread: https://warpdev.slack.com/archives/C0BDQDW8V5E/p1785947040574599

Conversation: https://staging.warp.dev/conversation/38020832-369f-4abd-82a6-cac6d8290474
Run: https://oz.staging.warp.dev/runs/019fd30e-587c-77c5-ae31-ed8bbc03bd6b

This PR was generated with Oz.