[APP-4908] Scope TUI model selection to the session - #14737
Conversation
Co-Authored-By: Warp Agent <agent@warp.dev>
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR moves TUI model selection from updating the active execution profile to setting a session-scoped Agent Mode override, adds (default) labeling for the active profile model, refreshes TUI surfaces on execution-profile setting changes, and adds coverage for the new behavior.
Concerns
⚠️ Selecting the displayed profile default can still create a stale per-session override for custom endpoints or custom routers, so the session may stop following future profile default changes.⚠️ This user-facing TUI change does not include accepted visual evidence in the PR description. Please attach a terminal transcript,render_to_lines/TuiBuffer::to_linessnapshot diff, or./script/run-tuicapture demonstrating the default label and session-scoped selection end to end.
Verdict
Found: 0 critical, 2 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
Co-Authored-By: Warp Agent <agent@warp.dev>
Description
Fixes the Warp Agent CLI model picker so choosing a model creates a session-scoped override instead of changing the active execution profile for every session.
The picker now resolves selection state for its terminal surface, labels the profile model with
(default), and refreshes the statusline and open picker when execution-profile settings change. Sessions without an override follow a newly configured profile default, while sessions with an override remain pinned.Linked Issue
APP-4908
ready-to-specorready-to-implement.Testing
cargo nextest run -p warp_tui— 952 passed; one existing test reported as leaky.Focused session-isolation and default-label tests passed.
./script/format --checkpassed.Clippy passed for
warp_tuiandwarpwith warnings denied.Manually verified with
./script/run-tuiunder tmux:(default);(default)marker.Additional full presubmit run skipped per request.
I have manually tested my changes locally with
./script/run-tuiAgent Mode
CHANGELOG-BUG-FIX: Fixed the Warp Agent CLI model picker changing the default model for every session.
CHANGELOG-TUI: Model selection now applies only to the current session and identifies the profile default.
Co-Authored-By: Warp Agent agent@warp.dev