Bump command-signatures to pick up git worktree name autocomplete - #14764
Closed
warp-agent-staging[bot] wants to merge 2 commits into
Closed
Bump command-signatures to pick up git worktree name autocomplete#14764warp-agent-staging[bot] wants to merge 2 commits into
warp-agent-staging[bot] wants to merge 2 commits into
Conversation
Bumps the pinned warp-command-signatures dependency to a520a43213d3b2eae608b14e3b9b3a11ac4d41aa (command-signatures #302, closes #11542), which adds a worktrees generator sourced from `git worktree list --porcelain` wired into the git worktree lock/move/remove/unlock args. Co-Authored-By: Warp Agent <agent@warp.dev>
…d-signatures-worktree
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps the pinned
warp-command-signaturesdependency so the client ships the git worktree name autocomplete added upstream. None of the upstream work reaches users until the client picks up the new revision.Cargo.toml:warp-command-signaturesrev4990fa1d4f5a9c74251c7330484a7ab6f3d38ac1→a520a43213d3b2eae608b14e3b9b3a11ac4d41aaCargo.lock: thewarp-command-signaturesandwarp-completion-metadatasource-rev entries updated to match (scoped to only these two packages — no unrelated dependency churn)The target revision is the current
mainHEAD ofwarpdotdev/command-signaturesand corresponds to warpdotdev/command-signatures#302 ("Add git worktree name autocomplete suggestions"), which closes #11542. It adds aworktreesgenerator sourced fromgit worktree list --porcelain(main worktree excluded) wired into thegit worktree lock/move/remove/unlockargs injson/git.json.Scope verification
4990fa1is a strict ancestor of the targeta520a43, so this does not regress the previously picked-uppkillcompletion spec.command-signatures/json/git.jsonandcommand-signatures/src/generators/git.rs. No unrelated or breaking upstream changes are dragged in.rust-embed, viasignature_by_name/dynamic_command_signature_data()); nothing is vendored, cached, or code-generated in this repo from the specs, and no client test fixture/snapshot asserts over the spec set — so no regeneration step is required for this bump.Verification
Testing-exempt category: dependency/version-bump (per factory-verification). No new regression test is added — a test here could only assert the pinned rev string, not detect a logic defect; the new behavior lives and is tested in the upstream command-signatures repo (validated by its own CI on #302).
Deterministic checks run locally (writable
CARGO_HOME/CARGO_TARGET_DIR):cargo check --locked -p warp_completer— passes;--lockedconfirms the scopedCargo.lockis self-consistent andwarp_completercompiles against the new rev.cargo fmt --check -p warp_completer— clean.cargo clippy --locked -p warp_completer --all-targets— clean, no warnings.cargo nextest run -p warp_completer— 138 passed. The 25 failures are a pre-existing environment issue unrelated to this change: an identicalwarp_featurespanic (crates/warp_features/src/lib.rs:1052:13, "Tried to check FeatureFlag::CloudEnvironments before feature flags were initialized"). The same tests fail identically on the unmodified base commit, and none of the failures reference command-signatures/worktree/git.json.Not user-facing to author in this repo: this is a pin bump with no client-side behavior authored here, so no computer-use visual proof is expected/attached.
CHANGELOG-IMPROVEMENT: Add autocomplete suggestions for git worktree names in
git worktree lock/move/remove/unlockOriginating thread: https://warpdev.slack.com/archives/C0BDQDW8V5E/p1785969286177199
This PR was generated with Oz.