docs(skills): require screenshots or videos for UI-impacting PRs#9701
Merged
Merged
Conversation
Update the review-pr-local skill so the agent analyzes the PR description and comments for screenshots or videos when changes are user-visible. If visual evidence is missing for a UI-impacting change, the agent should request changes and ask for a screenshot or short video of the feature working end to end. Co-Authored-By: Oz <oz-agent@warp.dev>
github-actions
Bot
added
the
external-contributor
captainsafia
removed
the
external-contributor
captainsafia
marked this pull request as ready for review
May 1, 2026 02:59
Contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and posted feedback on this pull request. Comment Powered by Oz |
moirahuang
approved these changes
May 1, 2026
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Overview
This PR updates the repository-specific review-pr-local skill to require screenshots, GIFs, or videos for UI-impacting PRs and to request changes when that evidence is missing.
Concerns
- The new behavior is added to the local companion skill even though the base
review-prskill says local overrides may not redefine evidence rules or final recommendation behavior. As written, the intended blocking screenshot/video requirement can conflict with or be ignored by the core workflow.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
| - Treat markdown image/video embeds (``, `<img ...>`, `<video ...>`), GitHub user-attachment links (e.g. `https://github.com/user-attachments/...`, `https://user-images.githubusercontent.com/...`), Loom links, and similar hosted media as valid evidence. | ||
| - The `Screenshots / Videos` section from `.github/pull_request_template.md` being present but empty does not count as evidence. | ||
| - If the change is UI-impacting and no screenshots or videos are attached in the description or comments, add an inline or summary-level comment requesting them. Use wording such as: "For faster review, please upload screenshots or a video of the feature working end to end." | ||
| - When required visual evidence is missing for a UI-impacting change, set the final recommendation in `summary` to `Request changes`, even if no other blocking issues were found. Call this out explicitly in the `## Verdict` section. |
Contributor
There was a problem hiding this comment.
review-pr skill and may not redefine evidence rules or final recommendation behavior, so this blocking visual-evidence requirement is out of scope here. Move the requirement into the core review-pr skill, or first make visual-evidence checks an allowed local override, so the workflow applies it reliably.
zerx-lab
pushed a commit
to zerx-lab/zap
that referenced
this pull request
May 3, 2026
…pdotdev#9701) ## Description Updates the `review-pr-local` skill so the PR review agent analyzes the PR description and comments for screenshots and videos when the change is UI-impacting. If visual evidence is missing for a user-visible change, the agent should ask for it (e.g. _"For faster review, please upload screenshots or a video of the feature working end to end."_) and treat the review as `Request changes`. This addresses the Slack thread asking the agent itself to request visual evidence on UI-impacting PRs and to make it (effectively) blocking. This is a new version of warpdotdev#9650, rebased on the current master branch. ## Linked Issue - [x] N/A — skill-only change. ## Screenshots / Videos N/A — docs-only change to a skill markdown file. ## Testing Reviewed the rendered markdown locally; no code changes. ## Agent Mode - [x] Warp Agent Mode - This PR was created via Warp's AI Agent Mode _Conversation: https://staging.warp.dev/conversation/ab81ec4d-60dc-4d12-a95e-51edfe581e0c_ _Run: https://oz.staging.warp.dev/runs/019de151-a557-712a-ac02-58a8d4fb90ec_ _This PR was generated with [Oz](https://warp.dev/oz)._ Co-authored-by: Oz <oz-agent@warp.dev>
1 task
zhaikong
pushed a commit
to zhaikong/warp
that referenced
this pull request
Jun 2, 2026
Stoica-Mihai
pushed a commit
to Stoica-Mihai/warp
that referenced
this pull request
Jun 5, 2026
…pdotdev#9701) ## Description Updates the `review-pr-local` skill so the PR review agent analyzes the PR description and comments for screenshots and videos when the change is UI-impacting. If visual evidence is missing for a user-visible change, the agent should ask for it (e.g. _"For faster review, please upload screenshots or a video of the feature working end to end."_) and treat the review as `Request changes`. This addresses the Slack thread asking the agent itself to request visual evidence on UI-impacting PRs and to make it (effectively) blocking. This is a new version of warpdotdev#9650, rebased on the current master branch. ## Linked Issue - [x] N/A — skill-only change. ## Screenshots / Videos N/A — docs-only change to a skill markdown file. ## Testing Reviewed the rendered markdown locally; no code changes. ## Agent Mode - [x] Warp Agent Mode - This PR was created via Warp's AI Agent Mode _Conversation: https://staging.warp.dev/conversation/ab81ec4d-60dc-4d12-a95e-51edfe581e0c_ _Run: https://oz.staging.warp.dev/runs/019de151-a557-712a-ac02-58a8d4fb90ec_ _This PR was generated with [Oz](https://warp.dev/oz)._ Co-authored-by: Oz <oz-agent@warp.dev>
Zollicoff
pushed a commit
to Zollicoff/warp
that referenced
this pull request
Jul 2, 2026
…pdotdev#9701) ## Description Updates the `review-pr-local` skill so the PR review agent analyzes the PR description and comments for screenshots and videos when the change is UI-impacting. If visual evidence is missing for a user-visible change, the agent should ask for it (e.g. _"For faster review, please upload screenshots or a video of the feature working end to end."_) and treat the review as `Request changes`. This addresses the Slack thread asking the agent itself to request visual evidence on UI-impacting PRs and to make it (effectively) blocking. This is a new version of warpdotdev#9650, rebased on the current master branch. ## Linked Issue - [x] N/A — skill-only change. ## Screenshots / Videos N/A — docs-only change to a skill markdown file. ## Testing Reviewed the rendered markdown locally; no code changes. ## Agent Mode - [x] Warp Agent Mode - This PR was created via Warp's AI Agent Mode _Conversation: https://staging.warp.dev/conversation/ab81ec4d-60dc-4d12-a95e-51edfe581e0c_ _Run: https://oz.staging.warp.dev/runs/019de151-a557-712a-ac02-58a8d4fb90ec_ _This PR was generated with [Oz](https://warp.dev/oz)._ Co-authored-by: Oz <oz-agent@warp.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates the
review-pr-localskill so the PR review agent analyzes the PR description and comments for screenshots and videos when the change is UI-impacting. If visual evidence is missing for a user-visible change, the agent should ask for it (e.g. "For faster review, please upload screenshots or a video of the feature working end to end.") and treat the review asRequest changes.This addresses the Slack thread asking the agent itself to request visual evidence on UI-impacting PRs and to make it (effectively) blocking.
This is a new version of #9650, rebased on the current master branch.
Linked Issue
Screenshots / Videos
N/A — docs-only change to a skill markdown file.
Testing
Reviewed the rendered markdown locally; no code changes.
Agent Mode
Conversation: https://staging.warp.dev/conversation/ab81ec4d-60dc-4d12-a95e-51edfe581e0c
Run: https://oz.staging.warp.dev/runs/019de151-a557-712a-ac02-58a8d4fb90ec
This PR was generated with Oz.