Allow setting the background color#213
Merged
Merged
Conversation
jonan
force-pushed
the
background-color
branch
from
4264476 to
d554ac8
Compare
Owner
|
Thanks. |
wasabeef
added a commit
that referenced
this pull request
Feb 16, 2016
Allow setting the background color
|
Now we can set the background color to any value, but i want to set the background to transparent, what should i do? @jonan |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last PR set the background to transparent (28f785a), but this wasn't a very good idea because it forces the view to be always on top (it changes the Z value).
I think that allowing to set the background color to any value is a better approach, so this PR reverts the previous commit and adds this functionality.
Sorry for sending the first PR on the first place