js-gatsby-staticsite2: drop the /using-ssr framework-test route - #4
Merged
Merged
Conversation
The route's getServerData() fetches an external API
(dog.ceo/api/breed/shiba/images/random). In CI that fetch does not fail
fast, it hangs: the harness's 5s HTTP_REQUEST_TIMEOUT_MS expires before
Gatsby returns anything, so the request errors out and fails the whole
job. PR #108 tried to absorb this by accepting HTTP 500 alongside 200,
but that only helps when the fetch fails quickly enough for
getServerData()'s catch-block to run and render a response — it never
reaches a status assertion when the request times out.
The route was already node-only ("stages": ["node"]), because EdgeJS
stages serve Gatsby from the static public/ output rather than running
`gatsby serve` (which hard-requires the lmdb native addon). So the route
validated nothing about EdgeJS — it only gated CI on a third-party
service's availability from GitHub runners. Remove it.
/using-dsg stays: it is also node-only but is served from build output
with no external dependency.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/using-ssr'sgetServerData()fetchesdog.ceo/api/breed/shiba/images/random. On GitHub runners that fetch hangs rather than failing fast, so the framework-test harness's 5sHTTP_REQUEST_TIMEOUT_MSexpires before Gatsby returns anything and the whole job fails.#108 tried to absorb this by accepting HTTP 500 alongside 200, but that only works when the fetch fails quickly enough for the
catchblock to render a 500 — a timed-out request never reaches a status assertion.The route was already
"stages": ["node"]-only, because EdgeJS stages serve Gatsby from staticpublic/output instead of runninggatsby serve(which hard-requires thelmdbnative addon). So it validated nothing about EdgeJS and only gated CI on a third-party service's availability. Removing it./using-dsgstays — also node-only, but served from build output with no external dependency.This unblocks the edgejs nightly pipeline, which has been red on every push to
mainsince 2026-06-30.Test
make framework-test-quickjs-native FRAMEWORK_TEST_SELECTOR=js-gatsby-staticsite2passes both stages with no regressions (3/3 routes on each).🤖 Generated with Claude Code