-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Create an Npm module and move PackageJson and Dependency there
#2506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
We can merge this one, right? |
PackageJson to AppSpecPackageJson and Npm dependency moduels
PackageJson and Npm dependency moduelsPackageJson and Npm dependency moduels
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file was completely unused.
Funnily enough, one module did use the printDep function but it defined it locally (didn't import this one) 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, this is much better! Some small things, I commented on them.
Btw it would have helped in a PR like this with ton of files that have nothing but changes in the imports, if you said in the main comment that most of the changes are like that, and that you commented on specific files which are more interesting to look at. That would help me go fast through some files and focus on others, while now I had to focus on each one file not to miss anything, and still I almost missed some stuff because it all looks the same after Nth file hah.
EDIT: you did comment on some though, I am aware of that! Just I didn't know if you commented on all, so I had again to be very careful.
My bad, it used to be clear from the PR's name but then I changed it (for the worse it seems). |
PackageJson and Npm dependency moduelsPackageJson and Dependency there
PackageJson and Dependency thereNpm module and move PackageJson and Dependency there
I had this on my refactoring list.
PackageJsonis a part of theAppSpecbut was inExternalConfig, which meansAppSpecdepended onExternalConfig.On the other hand,
Dependencywas part ofAppSpec, soExternalConfigalso depends onAppSpecThis PR introduces a new
Npmmodule and fixes the circular dependency.