Skip to content

Conversation

@sugardave
Copy link
Contributor

Add a note as a reminder to have Wasp generate the GetTasks type.

Description

Just a doc improvement suggestion for TypeScript devs to alleviate IDE squiggles while running through the ToDo App tutorial.

Select what type of change this PR introduces:

  1. Just code/docs improvement (no functional change).
  2. Bug fix (non-breaking change which fixes an issue).
  3. New feature (non-breaking change which adds functionality).
  4. Breaking change (fix or feature that would cause existing functionality to not work as expected).

Update Waspc ChangeLog and version if needed

If you did a bug fix, new feature, or breaking change, that affects waspc, make sure you satisfy the following:

  1. I updated ChangeLog.md with description of the change this PR introduces.
  2. I bumped waspc version in waspc.cabal to reflect changes I introduced, with regards to the version of the latest wasp release, if the bump was needed.

Update example apps if needed

If you did code changes and added a new feature or modified an existing feature, make sure you satisfy the following:

  1. I updated waspc/examples/todoApp as needed (updated modified feature or added new feature) and manually checked it works correctly.
  2. I updated waspc/headless-test/examples/todoApp and its e2e tests as needed (updated modified feature and its tests or added new feature and new tests for it).

Add a note as a reminder to have Wasp generate the `GetTasks` type.
@sugardave
Copy link
Contributor Author

I just realized that this might happen automatically and I was unaware because I am running everything in WSL 2 and experiencing the issue detailed in #603

Copy link
Member

@cprecioso cprecioso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, I think it's a good idea to add the tip, but a couple of things:

  • You've edited the web/versioned_docs folder, which is an archive of old versions, and won't edit the current docs. You should do this change in the same place but under web/docs instead.
  • No need to say "If you're using TypeScript", you correctly added the note in the TypeScript tab so we know that is the case.
  • I'd change the message to say that wasp start should have been running already and to make sure that is the case.

@cprecioso cprecioso assigned cprecioso and unassigned cprecioso Mar 31, 2025
@sugardave
Copy link
Contributor Author

Done and done.

You've edited the web/versioned_docs

It's where the Edit this page link took me. So, probably need another PR for that. I will look into it.

@cprecioso cprecioso merged commit e630101 into wasp-lang:release Apr 1, 2025
@cprecioso
Copy link
Member

Merged, thanks @sugardave!

@sugardave sugardave deleted the patch-1 branch April 1, 2025 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants