Discovery #505
Merged
Discovery #505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
germanattanasio
previously requested changes
Dec 14, 2016
discovery/README.md
Outdated
| <dependency> | ||
| <groupId>com.ibm.watson.developer_cloud</groupId> | ||
| <artifactId>discovery</artifactId> | ||
| <version>3.5.2</version> |
discovery/README.md
Outdated
| The [Discovery][discovery] wraps the environment, collection, configuration, document, and query operations of the Discovery service. | ||
|
|
||
| ```java | ||
| Discovery service = new Discovery("2016-12-01"); |
Contributor
There was a problem hiding this comment.
I think it's 2016-12-15. In any casem we need it to be the same as in the documentation
| import java.util.Date; | ||
|
|
||
| /** | ||
| * @author apturgeo |
Contributor
There was a problem hiding this comment.
Can you add some lines describing what the class does?
| private String name; | ||
| //TODO make this an enum | ||
| @SerializedName(STATUS) | ||
| private String status; |
Contributor
There was a problem hiding this comment.
Time to make it an enum ?
| import com.ibm.watson.developer_cloud.discovery.v1.model.collection.field.Field; | ||
|
|
||
| /** | ||
| * @author apturgeo |
| /** | ||
| * Copyright 2016 IBM Corp. All Rights Reserved. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with |
Contributor
There was a problem hiding this comment.
120 max line width
| @@ -0,0 +1,64 @@ | |||
| /** | |||
Contributor
There was a problem hiding this comment.
I think Aggregation should be enough as a class name. No need to have Query at the beginning.
Contributor
|
@maniax89 update your github profile!!! |
Contributor
Author
|
Here is a rough list of things I have not done yet (but probably will not have time to do):
|
kognate
dismissed
germanattanasio’s stale review
He made a bunch of changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This introduces Discovery service to the java-sdk
Other Information
good luck reviewing it!
Thanks for contributing to the Watson Developer Cloud!