Skip to content

Conversation

@blakesteve
Copy link
Contributor

Related to #635

Reverts the encoding so TTS won't read "+" when returning a space.

@blakesteve blakesteve self-assigned this Apr 4, 2017
@blakesteve blakesteve changed the title [text to speech] Temporary commit reversion [text to speech] Special Character failure resolution Apr 4, 2017
@josepmao
Copy link

josepmao commented Apr 5, 2017

@blakesteve @germanattanasio
I do not think just remove String encodedText = RequestUtils.encode(text); can be a proper change here. It will cause problem in #602 come back again. I suppose you add the RequestUtils.encode(text) to avoid that, and even in the workaround from #602, it give extra with .replace("+", "%20") after called URLEncoder.encode() to avoid the problem reported in #635 , although looks it is not a proper fix.

should we consider change to use POST? If keep using GET, agree with #635 at least need to modifying RequestBuilder to escape semicolons properly

@blakesteve
Copy link
Contributor Author

blakesteve commented Apr 5, 2017

@josepmao with commit 19948d5 the semicolon gets properly encoded before sent to the server, and testing against the string you provided in #602 it resolves the issue, unless I'm mistaken?

Copy link
Contributor

@germanattanasio germanattanasio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josepmao
Copy link

josepmao commented Apr 5, 2017

@blakesteve thanks for the response. Get it now :-)

@germanattanasio germanattanasio merged commit f9899ba into develop Apr 5, 2017
@germanattanasio germanattanasio deleted the encoding-revert branch April 7, 2017 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants