Skip to content

[text to speech] Special Character failure resolution #638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 5, 2017
Merged

[text to speech] Special Character failure resolution #638

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2aa5214
revert merge conflict resolution
blakesteve Apr 4, 2017
d370f00
Merge branch 'develop' into encoding-revert
germanattanasio Apr 4, 2017
19948d5
:bug: escape semicolon prior to sending to server
blakesteve Apr 4, 2017
4520f02
Merge branch 'encoding-revert' of https://github.com/watson-developer…
blakesteve Apr 4, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions ...o-speech/src/main/java/com/ibm/watson/developer_cloud/text_to_speech/v1/TextToSpeech.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
import com.ibm.watson.developer_cloud.text_to_speech.v1.model.Pronunciation;
import com.ibm.watson.developer_cloud.text_to_speech.v1.model.Voice;
import com.ibm.watson.developer_cloud.util.GsonSingleton;
import com.ibm.watson.developer_cloud.util.RequestUtils;
import com.ibm.watson.developer_cloud.util.ResponseConverterUtils;
import com.ibm.watson.developer_cloud.util.ResponseUtils;
import com.ibm.watson.developer_cloud.util.Validator;
Expand Down Expand Up @@ -216,10 +215,10 @@ public ServiceCall<InputStream> synthesize(final String text, final Voice voice,
String customizationId) {
Validator.isTrue((text != null) && !text.isEmpty(), "text cannot be null or empty");
Validator.isTrue(voice != null, "voice cannot be null or empty");
String encodedText = RequestUtils.encode(text);

String modifiedText = text.replace(";", "%3B");
final RequestBuilder request = RequestBuilder.get(PATH_SYNTHESIZE);
request.query(TEXT, encodedText);
request.query(TEXT, modifiedText);
request.query(VOICE, voice.getName());
request.query(ACCEPT, audioFormat != null ? audioFormat : AudioFormat.WAV);

Expand Down