Skip to content

Conversation

@lpatino10
Copy link
Contributor

@lpatino10 lpatino10 commented Mar 23, 2018

Fixes #899

This PR updates the main README as well as the individual service READMEs to make any changes in the examples for the v5.0 release, as well as to make formatting consistent throughout.

@codecov-io
Copy link

codecov-io commented Mar 23, 2018

Codecov Report

Merging #902 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #902   +/-   ##
==========================================
  Coverage      66.05%   66.05%           
  Complexity      2610     2610           
==========================================
  Files            544      544           
  Lines          14004    14004           
  Branches         817      817           
==========================================
  Hits            9250     9250           
  Misses          4340     4340           
  Partials         414      414

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 351a1c9...8497462. Read the comment docs.

@germanattanasio
Copy link
Contributor

This looks but we need to update the .bumpconfig file to make sure the places where the version was not updated will get updated on our next release

@lpatino10
Copy link
Contributor Author

The one place that won't get captured by bumpversion is the SNAPSHOT version in the main README. Unfortunately, after experimenting a bit, I can't find an easy way to add that to our bumpversion configuration file, so we might just have to manually change that when we release.

@germanattanasio germanattanasio merged commit 8dac882 into develop Mar 26, 2018
@lpatino10 lpatino10 deleted the readme-fixes branch March 26, 2018 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants