Skip to content

Conversation

@lpatino10
Copy link
Contributor

Recently, the NLC service added an endpoint called classifyCollection. This PR adds that service method, along with any associated models. Unit and integration tests were also added.

@codecov-io
Copy link

codecov-io commented Apr 2, 2018

Codecov Report

Merging #909 into develop will increase coverage by <.01%.
The diff coverage is 67.34%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #909      +/-   ##
=============================================
+ Coverage      65.84%   65.84%   +<.01%     
- Complexity      2613     2621       +8     
=============================================
  Files            547      551       +4     
  Lines          14073    14122      +49     
  Branches         817      818       +1     
=============================================
+ Hits            9266     9299      +33     
- Misses          4393     4409      +16     
  Partials         414      414
Impacted Files Coverage Δ Complexity Δ
...e_classifier/v1/model/CreateClassifierOptions.java 57.5% <ø> (ø) 5 <0> (ø) ⬇️
...guage_classifier/v1/NaturalLanguageClassifier.java 62.5% <100%> (+4.68%) 9 <1> (+1) ⬆️
...l_language_classifier/v1/model/CollectionItem.java 25% <25%> (ø) 1 <1> (?)
..._classifier/v1/model/ClassificationCollection.java 25% <25%> (ø) 1 <1> (?)
...classifier/v1/model/ClassifyCollectionOptions.java 68.96% <68.96%> (ø) 3 <3> (?)
...al_language_classifier/v1/model/ClassifyInput.java 75% <75%> (ø) 2 <2> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0506ea0...1dd5de7. Read the comment docs.

@germanattanasio germanattanasio merged commit b3713c3 into develop Apr 2, 2018
@lpatino10 lpatino10 deleted the add-classify-collection branch April 2, 2018 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants