Skip to content

Conversation

@lpatino10
Copy link
Contributor

This PR contains changes for release v6.7.0 of the Java SDK using the following commits:

  • Codegen: 4e7a739d8a08e2e18149521400cc26e0ff378280
  • API definition: 8e785da94f0c8d62ade5f8c54c1b73447b9aa321

Full details will be in the changelog upon release.

@codecov-io
Copy link

codecov-io commented Sep 20, 2018

Codecov Report

Merging #988 into master will increase coverage by 24.77%.
The diff coverage is 84.04%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master     #988       +/-   ##
=============================================
+ Coverage     40.51%   65.29%   +24.77%     
- Complexity     1728     3101     +1373     
=============================================
  Files           647      673       +26     
  Lines         15946    16264      +318     
  Branches        902      909        +7     
=============================================
+ Hits           6460    10619     +4159     
+ Misses         9118     5171     -3947     
- Partials        368      474      +106
Impacted Files Coverage Δ Complexity Δ
...eveloper_cloud/speech_to_text/v1/SpeechToText.java 92.05% <ø> (+17.05%) 87 <0> (+40) ⬆️
...loud/speech_to_text/v1/model/AddCorpusOptions.java 61.36% <ø> (ø) 6 <0> (ø) ⬇️
...ud/speech_to_text/v1/model/DeleteAudioOptions.java 62.5% <ø> (ø) 3 <0> (ø) ⬇️
...cloud/speech_to_text/v1/model/GetAudioOptions.java 62.5% <ø> (ø) 3 <0> (ø) ⬇️
...loud/speech_to_text/v1/model/GetCorpusOptions.java 62.5% <ø> (ø) 3 <0> (ø) ⬇️
...d/speech_to_text/v1/model/DeleteCorpusOptions.java 62.5% <ø> (ø) 3 <0> (ø) ⬇️
...developer_cloud/assistant/v1/model/OutputData.java 57.69% <ø> (-0.38%) 5 <0> (-1)
...cloud/speech_to_text/v1/model/AddAudioOptions.java 65.95% <ø> (+4.25%) 7 <0> (ø) ⬇️
.../watson/developer_cloud/service/WatsonService.java 60.41% <0%> (+13.04%) 41 <0> (+5) ⬆️
...loper_cloud/assistant/v2/model/MessageContext.java 100% <100%> (ø) 5 <5> (?)
... and 357 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a98f26...467af69. Read the comment docs.

Copy link
Contributor

@mediumTaj mediumTaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good! Let's make sure we are working in production tomorrow before merging

final List<String> messages = Arrays.asList(
"I want some pizza.",
"I'd like 3 pizzas.",
"Large"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is exactly how i talk :)

@lpatino10
Copy link
Contributor Author

@mediumTaj Should I merge the changes from the disable-ssl-verification branch into this release?

@mediumTaj
Copy link
Contributor

Yes let’s add it to this release

…ication

Add ability to disable SSL verification
@lpatino10 lpatino10 merged commit 4353541 into master Sep 22, 2018
@lpatino10 lpatino10 deleted the codegen-updates branch September 22, 2018 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants