make sure to add all modules for instalation#164
Merged
jsstylos merged 3 commits intowatson-developer-cloud:masterfrom Feb 23, 2017
kognate:issues/163
Merged
make sure to add all modules for instalation#164jsstylos merged 3 commits intowatson-developer-cloud:masterfrom kognate:issues/163
jsstylos merged 3 commits intowatson-developer-cloud:masterfrom
kognate:issues/163
Conversation
Codecov Report
@@ Coverage Diff @@
## master #164 +/- ##
==========================================
- Coverage 82.1% 79.57% -2.53%
==========================================
Files 24 24
Lines 1028 1028
==========================================
- Hits 844 818 -26
- Misses 184 210 +26
Continue to review full report at Codecov.
|
Contributor
|
@kognate can you revert the I think the way we do releases is using |
Contributor
This reverts commit 187dbc9.
Contributor
Author
|
@german I reverted it. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #163 because on release these files weren't included and I was able to replicate the reporters findings only when using a clean vm to test with.