Skip to content

make sure to add all modules for instalation#164

Merged
jsstylos merged 3 commits intowatson-developer-cloud:masterfrom
kognate:issues/163
Feb 23, 2017
Merged

make sure to add all modules for instalation#164
jsstylos merged 3 commits intowatson-developer-cloud:masterfrom
kognate:issues/163

Conversation

@kognate
Copy link
Copy Markdown
Contributor

@kognate kognate commented Feb 23, 2017

This fixes #163 because on release these files weren't included and I was able to replicate the reporters findings only when using a clean vm to test with.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 23, 2017

Codecov Report

Merging #164 into master will decrease coverage by -2.53%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #164      +/-   ##
==========================================
- Coverage    82.1%   79.57%   -2.53%     
==========================================
  Files          24       24              
  Lines        1028     1028              
==========================================
- Hits          844      818      -26     
- Misses        184      210      +26
Impacted Files Coverage Δ
watson_developer_cloud/language_translator_v2.py 44.82% <ø> (-31.04%)
..._developer_cloud/watson_developer_cloud_service.py 65.07% <ø> (-6.88%)
watson_developer_cloud/dialog_v1.py 38.88% <ø> (-5.56%)
watson_developer_cloud/document_conversion_v1.py 93.75% <ø> (-3.13%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78cf905...a516749. Read the comment docs.

@germanattanasio
Copy link
Copy Markdown
Contributor

@kognate can you revert the bump version commit ?

I think the way we do releases is using bumpversion. So we first do all the code changes and then we do bumpversion patch

@germanattanasio
Copy link
Copy Markdown
Contributor

This reverts commit 187dbc9.
@kognate
Copy link
Copy Markdown
Contributor Author

kognate commented Feb 23, 2017

@german I reverted it.

Copy link
Copy Markdown
Contributor

@jsstylos jsstylos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweeeet

@jsstylos jsstylos merged commit c067117 into watson-developer-cloud:master Feb 23, 2017
@belgort belgort mentioned this pull request Feb 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Error importing library

4 participants