Skip to content

Add content language parameter to Tone Analyzer#219

Closed
shubhanjan99 wants to merge 1 commit intowatson-developer-cloud:masterfrom
shubhanjan99:master
Closed

Add content language parameter to Tone Analyzer#219
shubhanjan99 wants to merge 1 commit intowatson-developer-cloud:masterfrom
shubhanjan99:master

Conversation

@shubhanjan99
Copy link
Copy Markdown

No description provided.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jun 1, 2017

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jun 1, 2017

Codecov Report

Merging #219 into master will decrease coverage by 2.65%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #219      +/-   ##
==========================================
- Coverage   84.23%   81.58%   -2.66%     
==========================================
  Files          24       24              
  Lines        1161     1162       +1     
==========================================
- Hits          978      948      -30     
- Misses        183      214      +31
Impacted Files Coverage Δ
watson_developer_cloud/tone_analyzer_v3.py 100% <100%> (ø) ⬆️
watson_developer_cloud/language_translator_v2.py 44.82% <0%> (-31.04%) ⬇️
..._developer_cloud/watson_developer_cloud_service.py 63.54% <0%> (-9.38%) ⬇️
watson_developer_cloud/dialog_v1.py 38.88% <0%> (-5.56%) ⬇️
watson_developer_cloud/document_conversion_v1.py 93.75% <0%> (-3.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 272412e...6727f4c. Read the comment docs.

@shubhanjan99
Copy link
Copy Markdown
Author

@germanattanasio is this PR being closed because of code coverage decrease?

@germanattanasio
Copy link
Copy Markdown
Contributor

germanattanasio commented Jun 14, 2017 via email

@shubhanjan99
Copy link
Copy Markdown
Author

Can you please point me to that PR. I don't yet see the language parameter in the master branch. The last PR with changes to Tone was this. I don't see my changes there either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants