Skip to content

[discovery] Add update_document method#233

Merged
germanattanasio merged 2 commits intowatson-developer-cloud:masterfrom
maniax89:discovery_update_document
Jul 11, 2017
Merged

[discovery] Add update_document method#233
germanattanasio merged 2 commits intowatson-developer-cloud:masterfrom
maniax89:discovery_update_document

Conversation

@maniax89
Copy link
Copy Markdown
Contributor

Adds in the https://watson-api-explorer.mybluemix.net/apis/discovery-v1#!/Documents/updateDocument method for Discovery that was missing. Required in order to have control over document ID when uploading (as well as being able to change an existing document without 2 steps of delete + add)

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jul 11, 2017

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jul 11, 2017

Codecov Report

Merging #233 into master will decrease coverage by 2.89%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #233     +/-   ##
=========================================
- Coverage   84.31%   81.42%   -2.9%     
=========================================
  Files          24       24             
  Lines        1167     1179     +12     
=========================================
- Hits          984      960     -24     
- Misses        183      219     +36
Impacted Files Coverage Δ
watson_developer_cloud/discovery_v1.py 97.63% <75%> (-2.37%) ⬇️
watson_developer_cloud/language_translator_v2.py 44.82% <0%> (-31.04%) ⬇️
..._developer_cloud/watson_developer_cloud_service.py 63.54% <0%> (-9.38%) ⬇️
watson_developer_cloud/tone_analyzer_v3.py 92.3% <0%> (-7.7%) ⬇️
watson_developer_cloud/dialog_v1.py 38.88% <0%> (-5.56%) ⬇️
watson_developer_cloud/document_conversion_v1.py 93.75% <0%> (-3.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08761ca...b454877. Read the comment docs.

@maniax89 maniax89 force-pushed the discovery_update_document branch from 407c349 to 543faad Compare July 11, 2017 14:29
@germanattanasio germanattanasio merged commit afc99df into watson-developer-cloud:master Jul 11, 2017
@maniax89 maniax89 deleted the discovery_update_document branch July 11, 2017 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants