Skip to content

x_watson_learning_opt_out for natural language understanding#246

Merged
jsstylos merged 2 commits intowatson-developer-cloud:masterfrom
samuel500:master
Aug 2, 2017
Merged

x_watson_learning_opt_out for natural language understanding#246
jsstylos merged 2 commits intowatson-developer-cloud:masterfrom
samuel500:master

Conversation

@samuel500
Copy link
Copy Markdown
Contributor

No description provided.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Aug 2, 2017

CLA assistant check
All committers have signed the CLA.

@samuel500
Copy link
Copy Markdown
Contributor Author

Is the fact that it failed with Python 2.7 actually an issue?

@germanattanasio
Copy link
Copy Markdown
Contributor

Hi @samuel500, What's the idea behind this pull requests?
Travis fails because of pylint issues

** Module watson_developer_cloud.natural_language_understanding_v1
C: 39, 0: No space allowed around keyword argument assignment
            x_watson_learning_opt_out = x_watson_learning_opt_out)
                                      ^ (bad-whitespace)

Once you fix the whitespace issue run sh pylint.sh to verify that the code passes the code style rules

@codecov-io
Copy link
Copy Markdown

codecov-io commented Aug 2, 2017

Codecov Report

Merging #246 into master will decrease coverage by 2.87%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #246      +/-   ##
==========================================
- Coverage   84.77%   81.89%   -2.88%     
==========================================
  Files          24       24              
  Lines        1182     1182              
==========================================
- Hits         1002      968      -34     
- Misses        180      214      +34
Impacted Files Coverage Δ
...veloper_cloud/natural_language_understanding_v1.py 100% <ø> (ø) ⬆️
watson_developer_cloud/language_translator_v2.py 44.82% <0%> (-31.04%) ⬇️
..._developer_cloud/watson_developer_cloud_service.py 66.66% <0%> (-9.38%) ⬇️
watson_developer_cloud/tone_analyzer_v3.py 92.3% <0%> (-7.7%) ⬇️
watson_developer_cloud/dialog_v1.py 38.88% <0%> (-5.56%) ⬇️
watson_developer_cloud/document_conversion_v1.py 93.75% <0%> (-3.13%) ⬇️
watson_developer_cloud/visual_recognition_v3.py 98.73% <0%> (-1.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33a653b...b6f9a56. Read the comment docs.

@samuel500
Copy link
Copy Markdown
Contributor Author

Ok, fixed the pylint issue.
The idea behind the pull request is to make it possible to opt out of Watson learning while using natural language understanding. For the service I'm building I need to give the option to users that the data they provide will not be used in any way. That is not possible right now using natural_language_understanding_v1.py.

@samuel500
Copy link
Copy Markdown
Contributor Author

Here's the documentation that is inaccurate without my pull:
https://www.ibm.com/watson/developercloud/natural-language-understanding/api/v1/?python#data-collection

@jsstylos jsstylos merged commit 4d0e2e4 into watson-developer-cloud:master Aug 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants