Skip to content

Update user agent string to include OS and Python version info#275

Merged
germanattanasio merged 1 commit intomasterfrom
mdk/update-user-agent-string
Oct 8, 2017
Merged

Update user agent string to include OS and Python version info#275
germanattanasio merged 1 commit intomasterfrom
mdk/update-user-agent-string

Conversation

@mkistler
Copy link
Copy Markdown

@mkistler mkistler commented Oct 8, 2017

Small update to add OS and Python version info to the user-agent string.

On my Mac, this results in:

{'user-agent': 'watson-apis-python-sdk-0.26.1 Darwin 16.7.0 2.7.12'}

In a docker container running the "python" image, this results in:

{'user-agent': 'watson-apis-python-sdk-0.26.1 Linux 4.9.49-moby 3.6.3'}

@mkistler mkistler requested a review from jsstylos October 8, 2017 14:12
@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 8, 2017

Codecov Report

Merging #275 into master will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #275      +/-   ##
==========================================
+ Coverage   85.22%   85.29%   +0.07%     
==========================================
  Files          24       24              
  Lines        1225     1231       +6     
==========================================
+ Hits         1044     1050       +6     
  Misses        181      181
Impacted Files Coverage Δ
..._developer_cloud/watson_developer_cloud_service.py 76.96% <100%> (+0.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4d3e36...24f738b. Read the comment docs.

Copy link
Copy Markdown
Contributor

@germanattanasio germanattanasio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope we don't run into issues when running this into an Arduino. It's a Unix so it should work.

@germanattanasio germanattanasio merged commit 8ba86b8 into master Oct 8, 2017
@ehdsouza ehdsouza deleted the mdk/update-user-agent-string branch October 17, 2017 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants