Add convert_model helper function and use this in generated code#294
Merged
germanattanasio merged 2 commits intov1.0.0from Nov 4, 2017
Merged
Add convert_model helper function and use this in generated code#294germanattanasio merged 2 commits intov1.0.0from
germanattanasio merged 2 commits intov1.0.0from
Conversation
germanattanasio
approved these changes
Nov 4, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
_convert_modelhelper function that is intended for use in converting models passed as input parameters to dicts for subsequent processing. This change was suggested by @jsstylos in this PR comment.This PR also adds the
list_training_examplesmethod in the Discovery service because swagger changes now make it possible to generate this method.