Store datetime properties as Python datetime objects in models #303
Merged
germanattanasio merged 3 commits intov1.0.0from Nov 10, 2017
Merged
Store datetime properties as Python datetime objects in models #303germanattanasio merged 3 commits intov1.0.0from
germanattanasio merged 3 commits intov1.0.0from
Conversation
Codecov Report
@@ Coverage Diff @@
## v1.0.0 #303 +/- ##
=========================================
+ Coverage 37.29% 38.09% +0.8%
=========================================
Files 24 24
Lines 8173 8187 +14
=========================================
+ Hits 3048 3119 +71
+ Misses 5125 5068 -57
Continue to review full report at Codecov.
|
germanattanasio
approved these changes
Nov 10, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds helper functions to convert to/from iso8601 datetimes and uses these functions in the
_from_dict()and_to_dict()methods of the models so that datetime values are stored as datetime objects and not simply strings.The PR also includes a minor update to VisualRecognitionV3 resulting from a recent update to the swagger.