Skip to content

Fix path encoding#305

Merged
germanattanasio merged 4 commits intov1.0.0from
mdk/fix-path-encoding
Nov 13, 2017
Merged

Fix path encoding#305
germanattanasio merged 4 commits intov1.0.0from
mdk/fix-path-encoding

Conversation

@mkistler
Copy link
Copy Markdown

The PR changes the way we handle path parameters. Path parameters are now encoded individually before substituting into the URL, so that all "special" characters (including "#" and "/") are percent-encoded in the resulting URL.

The PR also changes the lint script to lint the examples, and fixes lint all the lint errors/warnings in the examples.

Fixes #304

@mkistler mkistler force-pushed the mdk/fix-path-encoding branch from 0690282 to 5a0d7a0 Compare November 13, 2017 12:33
@codecov-io
Copy link
Copy Markdown

codecov-io commented Nov 13, 2017

Codecov Report

Merging #305 into v1.0.0 will increase coverage by 0.62%.
The diff coverage is 87.8%.

Impacted file tree graph

@@            Coverage Diff             @@
##           v1.0.0     #305      +/-   ##
==========================================
+ Coverage   38.09%   38.72%   +0.62%     
==========================================
  Files          24       24              
  Lines        8187     8292     +105     
==========================================
+ Hits         3119     3211      +92     
- Misses       5068     5081      +13
Impacted Files Coverage Δ
watson_developer_cloud/watson_service.py 82.75% <100%> (+0.14%) ⬆️
watson_developer_cloud/personality_insights_v3.py 44.23% <100%> (+0.15%) ⬆️
...veloper_cloud/natural_language_understanding_v1.py 31.43% <100%> (+0.16%) ⬆️
watson_developer_cloud/tone_analyzer_v3.py 27.88% <100%> (+0.4%) ⬆️
watson_developer_cloud/visual_recognition_v3.py 29.73% <100%> (+0.81%) ⬆️
..._developer_cloud/natural_language_classifier_v1.py 36.97% <100%> (+1.68%) ⬆️
watson_developer_cloud/language_translator_v2.py 53.27% <70%> (+0.38%) ⬆️
watson_developer_cloud/discovery_v1.py 30.01% <84.61%> (+0.91%) ⬆️
watson_developer_cloud/conversation_v1.py 40.82% <88%> (+0.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0fda95...5a0d7a0. Read the comment docs.

Copy link
Copy Markdown
Contributor

@germanattanasio germanattanasio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for handling this so quickly!

@germanattanasio germanattanasio merged commit 31721ed into v1.0.0 Nov 13, 2017
@germanattanasio germanattanasio deleted the mdk/fix-path-encoding branch November 14, 2017 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants