Fix path encoding#305
Merged
germanattanasio merged 4 commits intov1.0.0from Nov 13, 2017
Merged
Conversation
0690282 to
5a0d7a0
Compare
Codecov Report
@@ Coverage Diff @@
## v1.0.0 #305 +/- ##
==========================================
+ Coverage 38.09% 38.72% +0.62%
==========================================
Files 24 24
Lines 8187 8292 +105
==========================================
+ Hits 3119 3211 +92
- Misses 5068 5081 +13
Continue to review full report at Codecov.
|
germanattanasio
approved these changes
Nov 13, 2017
Contributor
germanattanasio
left a comment
There was a problem hiding this comment.
Thanks for handling this so quickly!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR changes the way we handle path parameters. Path parameters are now encoded individually before substituting into the URL, so that all "special" characters (including "#" and "/") are percent-encoded in the resulting URL.
The PR also changes the lint script to lint the examples, and fixes lint all the lint errors/warnings in the examples.
Fixes #304