Merge next to develop prior to 1.1.0 release#398
Merged
germanattanasio merged 67 commits intodevelopfrom Mar 8, 2018
Merged
Conversation
* 🆕 generated text-to-speech with latest swagger * 💚 added missing tests and updated method names in tests * Changes as per review Mike's comments * Remove unnecessary overview * 😒 Rename Bluemix to IBM Cloud * change Bluemix to IBM Cloud * fix capitalization of IBM CLoud * Update README.md * 📝 Update to use Watson APIs * Adding integration tests and removing REST description * enable dot_env to get env variables * Revert "enable dot_env to get env variables" This reverts commit f7ac60a. * Encrypt travis env file * Adding VCAP_SERVICES * Ignoring destructive tests * Remove the VCAP_SERVICES keyword * Regenerate encrypted env file for travis * Remove the skip test for integration test * Add in init file for integration tests * Update tests as per new env file
* 🆕 generated speech-to-text from latest swagger * 💚 add tests for acoustic customizations and update old tests * Regenerate speech to text * Manual tweaks for add_word * Regenerate to handle single content type * Remove content-type from tests
* Remove deprecated services * Remove unused dependencies
…yzer Regenerate tone analyzer
…translator Regenerate language translator
Regenerate natural language classifier
Regenerate natural language understanding
Regenerate discovery
Regenerate conversation and add more tests
…cognition Regenerate visual recognition
* Initial implementation of set using web sockets * Speech to text using web sockets * fix: Adding the pyOpenSSL * docs: Adding IBM copyright * refactor: Following clean coding practices better naming conventions, added method description in the method body * refactor(Better naming conventions): * refactor: removing the extra close signal * refactor: naming conventions, error message * Refactor: remove print * feat: Adding microphone example for speech to text
…ng for nested models related to issue: #359
Adding two step process that supports renamed props
…-text Regenerate speech to text
…peech Regenerate text to speech
…yzer Regenerate tone analyzer
Address pylint issues
…cognition Regenerate visual recognition
Rename integration tests
docs(python sdk): Updating the setup.py with new packages
ammardodin
reviewed
Mar 8, 2018
| from .watson_service import WatsonInvalidArgument | ||
| from .alchemy_data_news_v1 import AlchemyDataNewsV1 | ||
| from .alchemy_language_v1 import AlchemyLanguageV1 | ||
| from .alchemy_vision_v1 import AlchemyVisionV1 |
Contributor
There was a problem hiding this comment.
Instead of completely removing these, we can use some form deprecation messages like we do in node-sdk so that users who try to instantiate those classes get a clear deprecation message instead of just an error.
Contributor
There was a problem hiding this comment.
For this we will have to add the class files back and add the deprecation warnings in the class files
ammardodin
suggested changes
Mar 8, 2018
Contributor
ammardodin
left a comment
ammardodin
left a comment
There was a problem hiding this comment.
Overall looks good. Just a small suggestion.
Contributor
Author
|
@ammardodin I was talking to Erika and there is no easy way to do this without adding back the deprecated files |
ammardodin
approved these changes
Mar 8, 2018
Codecov Report
@@ Coverage Diff @@
## develop #398 +/- ##
==========================================
- Coverage 38.39% 0% -38.4%
==========================================
Files 25 21 -4
Lines 8720 10614 +1894
==========================================
- Hits 3348 0 -3348
- Misses 5372 10614 +5242
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: https://github.com/watson-developer-cloud/python-sdk/wiki/Changelog#version-110