fix(python): handling support for python 3.6.4#399
Merged
germanattanasio merged 2 commits intodevelopfrom Mar 8, 2018
Merged
Conversation
germanattanasio
approved these changes
Mar 8, 2018
|
|
||
| def build_close_message(self): | ||
| return json.dumps({'action': 'close'}) | ||
| return json.dumps({'action': 'close'}).encode('utf8') |
Contributor
Author
There was a problem hiding this comment.
This is for the error in python 3.6.4:
24, in onMessage
self.sendMessage(self.build_close_message())
File "/Users/erikadsouza/anaconda3/envs/python-3.6.4/lib/python3.6/site-packages/autobahn/websocket/protocol.py", line 2164, in sendMessage
assert(type(payload) == bytes)
builtins.AssertionError:
Codecov Report
@@ Coverage Diff @@
## develop #399 +/- ##
=======================================
Coverage 0% 0%
=======================================
Files 21 21
Lines 10614 10618 +4
=======================================
- Misses 10614 10618 +4
Continue to review full report at Codecov.
|
germanattanasio
suggested changes
Mar 8, 2018
| version='2017-10-16', | ||
| username=os.getenv('DISCOVERY_TO_TEXT_USERNAME'), | ||
| password=os.getenv('DISCOVERY_TO_TEXT_PASSWORD')) | ||
| username="YOUR SERVICE USERNAME", |
Contributor
There was a problem hiding this comment.
This should be os.getenv('DISCOVERY_USERNAME')
germanattanasio
approved these changes
Mar 8, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Got the following two errors in python 3.6.4:
*