Skip to content

fix(python sdk): Fix timestamps & context properties#413

Merged
germanattanasio merged 2 commits intodevelopfrom
codegen/assistant
Mar 21, 2018
Merged

fix(python sdk): Fix timestamps & context properties#413
germanattanasio merged 2 commits intodevelopfrom
codegen/assistant

Conversation

@ehdsouza
Copy link
Copy Markdown
Contributor

As quoted in issue in the swagger:

We had the created & updated properties still marked as required.
When we were merging the request & response models for Context, we left out the conversation_id and system to be required which is not true when in a request model but is valid on response model.
This fixes the above to two issues by making the properties to be optional so that the SDK's don't break.

Copy link
Copy Markdown

@anweshan anweshan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should regenerate assistant with what is on master, because now while you committed changes to conversation with digress_in etc, it's not in assistant

Copy link
Copy Markdown

@anweshan anweshan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has digress_in so it is good

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #413 into develop will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           develop    #413   +/-   ##
=======================================
  Coverage        0%      0%           
=======================================
  Files           22      22           
  Lines        12997   12971   -26     
=======================================
+ Misses       12997   12971   -26
Impacted Files Coverage Δ
watson_developer_cloud/assistant_v1.py 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23dbef0...1e26b8e. Read the comment docs.

@germanattanasio germanattanasio merged commit d3c1a9f into develop Mar 21, 2018
@ehdsouza ehdsouza deleted the codegen/assistant branch March 29, 2018 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants