Skip to content

fix(python conversation): Fix timestamp and context properties#414

Merged
germanattanasio merged 2 commits intodevelopfrom
codegen/conversation
Mar 21, 2018
Merged

fix(python conversation): Fix timestamp and context properties#414
germanattanasio merged 2 commits intodevelopfrom
codegen/conversation

Conversation

@ehdsouza
Copy link
Copy Markdown
Contributor

We had the created & updated properties still marked as required.
When we were merging the request & response models for Context, we left out the conversation_id and system to be required which is not true when in a request model but is valid on response model.
This fixes the above to two issues by making the properties to be optional so that the SDK

@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 20, 2018

Codecov Report

Merging #414 into develop will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           develop    #414   +/-   ##
=======================================
  Coverage        0%      0%           
=======================================
  Files           22      22           
  Lines        12997   13001    +4     
=======================================
- Misses       12997   13001    +4
Impacted Files Coverage Δ
watson_developer_cloud/conversation_v1.py 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23dbef0...3d87051. Read the comment docs.

Copy link
Copy Markdown

@anweshan anweshan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me

@germanattanasio germanattanasio merged commit dc88dd8 into develop Mar 21, 2018
@ehdsouza ehdsouza deleted the codegen/conversation branch March 29, 2018 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants