Skip to content

doc(readme): Update readme with assistantv2 note#584

Merged
ehdsouza merged 3 commits intomasterfrom
readme-assistantv2
Oct 23, 2018
Merged

doc(readme): Update readme with assistantv2 note#584
ehdsouza merged 3 commits intomasterfrom
readme-assistantv2

Conversation

@ehdsouza
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Oct 19, 2018

Codecov Report

Merging #584 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #584   +/-   ##
======================================
  Coverage       0%      0%           
======================================
  Files          26      26           
  Lines       17052   17052           
======================================
  Misses      17052   17052

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74d6d77...178eb90. Read the comment docs.

Copy link
Contributor

@mediumTaj mediumTaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Erika it looks a little out of place under Examples. can you either put this in Before you begin like Mamoon did in the Ruby SDK or have the header like you have in Go?
https://github.com/watson-developer-cloud/go-sdk/blob/ea804c3813d8cd43e2324007d7c678d3abdd46f6/README.md#assistantv2

Copy link
Contributor

@germanattanasio germanattanasio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ehdsouza unless is necessary don't update responses.

@ehdsouza ehdsouza merged commit 7ecc741 into master Oct 23, 2018
@ehdsouza ehdsouza deleted the readme-assistantv2 branch October 23, 2018 13:54
@watson-github-bot
Copy link
Collaborator

🎉 This PR is included in version 2.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

5 participants