fix: Default timeout for requests.request()#590
Merged
ehdsouza merged 1 commit intowatson-developer-cloud:masterfrom Oct 30, 2018
Merged
fix: Default timeout for requests.request()#590ehdsouza merged 1 commit intowatson-developer-cloud:masterfrom
ehdsouza merged 1 commit intowatson-developer-cloud:masterfrom
Conversation
This avoids a hard-to-diagnose hang condition when a request never gets a response (which often means a network level failure occurred). Strongly recommended by Python Requests for production use. See: http://docs.python-requests.org/en/master/user/quickstart/#timeouts
germanattanasio
approved these changes
Oct 29, 2018
Codecov Report
@@ Coverage Diff @@
## master #590 +/- ##
======================================
Coverage 0% 0%
======================================
Files 26 26
Lines 17052 17053 +1
======================================
- Misses 17052 17053 +1
Continue to review full report at Codecov.
|
ehdsouza
approved these changes
Oct 30, 2018
Collaborator
|
🎉 This PR is included in version 2.3.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids a hard-to-diagnose hang condition when a request never gets a response (which often means a network level failure occurred).
Strongly recommended by Python Requests for production use. See: http://docs.python-requests.org/en/master/user/quickstart/#timeouts